Conversation
The composer constraint moves from `~8.1 || …` to `~8.2 || … || ~8.5`, and three PostmarkAttachment factories gain `string` parameter types while two PostmarkOpen getters become nullable. All of those are breaking for consumers and none were recorded, so a release cut from this branch would have shipped as a minor. Adds the CHANGELOG entry marking this as v8.0.0 with each break called out. Also replaces the empty catch in the suppressions teardown with a STDERR warning — a cleanup failure left the list populated and broke the following run somewhere unrelated, with nothing on record pointing back here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ewood-ac
added a commit
that referenced
this pull request
Aug 5, 2026
Three changes to the client-identification headers: The version was a hand-maintained `public static $SDK_VERSION = '7.0.0'`. That has to be bumped by hand on every release and will silently go stale — at which point the telemetry these headers exist to provide is actively wrong, which is worse than absent. It now reads Composer's runtime metadata, falling back to a constant only when that is unavailable (source checkout, no installed package). The property was also public and mutable; the replacement is a method plus a const. The new User-Agent dropped the OS field that the old format carried. Anything parsing that string for platform breakdown would have gone blank without warning, so OS is back: `Postmark-SDK/<v> (PHP/<ver>; OS/<os>)`. Also drops this branch's composer.json and CI edits. They overlap with the ones in #164, which sets a wider range (adding 8.5 as well as dropping 8.1) and so supersedes them — leaving both would just conflict. The PHP-version decision belongs to that PR; this one is only about the headers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.