WG Demos - Update editorType/widget import statements in components - #34545
Open
16adianay wants to merge 1 commit into
Open
WG Demos - Update editorType/widget import statements in components#3454516adianay wants to merge 1 commit into
16adianay wants to merge 1 commit into
Conversation
…-related widget demos Update editorType/widget import statements
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates WG demo sources to rely on DevExtreme core widget modules (e.g., devextreme/ui/*) instead of framework-wrapper “side-effect” imports and (in Angular) removes some devextreme-angular widget modules from standalone component imports, aligning demos with the current module/import conventions.
Changes:
- Replaced framework wrapper widget imports (e.g.,
devextreme-react/text-area,devextreme-vue/select-box) with DevExtreme core widget imports (e.g.,devextreme/ui/text_area,devextreme/ui/select_box). - Simplified Angular standalone component module imports by removing specific widget modules (e.g.,
DxSelectBoxModule) when the widget is used via FormeditorType/ Toolbarwidgetstring. - Adjusted demo files across Angular/React/ReactJs/Vue for Stepper and Form-related demos to keep runtime editor/widget registration working via
devextreme/ui/*.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/demos/Demos/Toolbar/Overview/Angular/app/app.component.ts | Removes DxSelectBoxModule and switches SelectBox registration to devextreme/ui/select_box. |
| apps/demos/Demos/Stepper/FormIntegration/Vue/RoomMealPlanTemplate.vue | Switches SelectBox registration to devextreme/ui/select_box. |
| apps/demos/Demos/Stepper/FormIntegration/Vue/GuestsTemplate.vue | Removes wrapper NumberBox side-effect import (needs core widget registration). |
| apps/demos/Demos/Stepper/FormIntegration/Vue/DatesTemplate.vue | Switches DateRangeBox registration to devextreme/ui/date_range_box. |
| apps/demos/Demos/Stepper/FormIntegration/Vue/AdditionalTemplate.vue | Switches TextArea registration to devextreme/ui/text_area. |
| apps/demos/Demos/Stepper/FormIntegration/ReactJs/RoomMealPlanForm.js | Switches SelectBox registration to devextreme/ui/select_box. |
| apps/demos/Demos/Stepper/FormIntegration/ReactJs/GuestsForm.js | Removes wrapper NumberBox side-effect import (needs core widget registration). |
| apps/demos/Demos/Stepper/FormIntegration/ReactJs/DatesForm.js | Switches DateRangeBox registration to devextreme/ui/date_range_box. |
| apps/demos/Demos/Stepper/FormIntegration/ReactJs/Confirmation.js | Removes wrapper DateRangeBox side-effect import. |
| apps/demos/Demos/Stepper/FormIntegration/ReactJs/AdditionalForm.js | Switches TextArea registration to devextreme/ui/text_area. |
| apps/demos/Demos/Stepper/FormIntegration/React/RoomMealPlanForm.tsx | Switches SelectBox registration to devextreme/ui/select_box. |
| apps/demos/Demos/Stepper/FormIntegration/React/GuestsForm.tsx | Removes wrapper NumberBox side-effect import (needs core widget registration). |
| apps/demos/Demos/Stepper/FormIntegration/React/DatesForm.tsx | Switches DateRangeBox registration to devextreme/ui/date_range_box. |
| apps/demos/Demos/Stepper/FormIntegration/React/Confirmation.tsx | Removes wrapper DateRangeBox side-effect import. |
| apps/demos/Demos/Stepper/FormIntegration/React/AdditionalForm.tsx | Switches TextArea registration to devextreme/ui/text_area. |
| apps/demos/Demos/Stepper/FormIntegration/Angular/app/room-meal-plan-form/room-meal-plan-form.component.ts | Removes DxSelectBoxModule and registers SelectBox via devextreme/ui/select_box. |
| apps/demos/Demos/Stepper/FormIntegration/Angular/app/guests-form/guests-form.component.ts | Removes DxNumberBoxModule from standalone imports (needs core widget registration). |
| apps/demos/Demos/Stepper/FormIntegration/Angular/app/dates-form/dates-form.component.ts | Removes DxDateRangeBoxModule and registers DateRangeBox via devextreme/ui/date_range_box. |
| apps/demos/Demos/Stepper/FormIntegration/Angular/app/additional-form/additional-form.component.ts | Removes DxTextAreaModule and registers TextArea via devextreme/ui/text_area. |
| apps/demos/Demos/Form/ItemCustomization/Vue/App.vue | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Form/ItemCustomization/ReactJs/App.js | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Form/ItemCustomization/React/App.tsx | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Form/ItemCustomization/Angular/app/app.component.ts | Removes Angular widget modules and registers SelectBox/TextArea via core widget imports. |
| apps/demos/Demos/Common/FormsOverview/Vue/App.vue | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Common/FormsOverview/ReactJs/App.js | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Common/FormsOverview/React/App.tsx | Replaces wrapper TextArea import with core widget imports (SelectBox/TextArea). |
| apps/demos/Demos/Common/FormsOverview/Angular/app/app.component.ts | Removes Angular widget modules and registers SelectBox/TextArea via core widget imports. |
Comment on lines
+6
to
+7
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
+64
to
+65
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
+6
to
+7
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
+5
to
+6
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
+14
to
+15
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
+5
to
+6
| import 'devextreme/ui/select_box'; | ||
| import 'devextreme/ui/text_area'; |
Comment on lines
1
to
5
| import { Component, Input, SimpleChanges, ViewChild } from '@angular/core'; | ||
| import { DxFormModule, DxNumberBoxModule } from 'devextreme-angular'; | ||
| import { DxFormModule } from 'devextreme-angular'; | ||
| import { DxFormComponent, type DxFormTypes } from 'devextreme-angular/ui/form'; | ||
| import { type DxNumberBoxTypes } from 'devextreme-angular/ui/number-box'; | ||
| import type { BookingFormData } from '../app.types'; |
Comment on lines
37
to
41
| <script setup lang="ts"> | ||
| import { DxForm, DxRangeRule, DxSimpleItem } from 'devextreme-vue/form'; | ||
| import 'devextreme-vue/number-box'; | ||
| import { watch, ref } from 'vue'; | ||
| import type { BookingFormData } from './types.ts'; | ||
| import { getInitialFormData } from './data.ts'; |
Comment on lines
1
to
3
| import React, { memo } from 'react'; | ||
| import { Form, RangeRule, SimpleItem } from 'devextreme-react/form'; | ||
| import 'devextreme-react/number-box'; | ||
|
|
Comment on lines
1
to
4
| import React, { memo } from 'react'; | ||
| import type { FC } from 'react'; | ||
| import { Form, RangeRule, SimpleItem } from 'devextreme-react/form'; | ||
| import 'devextreme-react/number-box'; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
How did you achieve this?
How can we verify these changes?