chore(security): patch vulnerable deps and harden CI - #4030
Open
charlesvien wants to merge 7 commits into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AI### Issue 1
.github/scripts/react-doctor/package.json:1
**Runner manifests bypass CI**
Changes limited to this manifest or its lockfile do not match the React Doctor workflow's path filters, so a broken lockfile or incompatible update is not validated until a later source-code pull request triggers `npm ci`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "pin react-doctor and scope its write per..." | Re-trigger Greptile |
charlesvien
force-pushed
the
chore/ci-security-hardening
branch
4 times, most recently
from
July 31, 2026 05:29
9549c24 to
2ce743b
Compare
charlesvien
force-pushed
the
chore/ci-security-hardening
branch
from
July 31, 2026 05:46
2ce743b to
761254b
Compare
charlesvien
force-pushed
the
chore/ci-security-hardening
branch
from
July 31, 2026 06:27
017884b to
510e5bc
Compare
tatoalo
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The desktop app's dependency tree carries known CVEs (critical: protobufjs, simple-git, tar; high: axios) flagged during the monorepo import review.
Note: Temporarily removing react-doctor due to poor security patterns that workflow has, will add it back in monorepo properly in a follow-up PR.
Changes
simple-git^3.32.3andtar^7.5.19as direct floors, plusprotobufjs7.6.5 andaxios1.18.1 as transitive overrides. Every resolved version is well over the 7-dayminimumReleaseAgeand clears its advisories.react-doctor.yml: install react-doctor from a pinned, integrity-locked lockfile (.github/scripts/react-doctor/) vianpm ciinstead ofnpx --yes(no unverified runtime fetch).pull-requests: writeis scoped to the single job that posts the sticky comment instead of the whole workflow.encryption.ts: pass{ authTagLength: 16 }tocreateDecipherivso a shorter forged tag cannot be accepted (semgrepgcm-no-tag-length).How did you test this?
pnpm install --frozen-lockfilepasses on the regenerated lockfile.pnpm auditshows the four flagged packages (protobufjs, simple-git, tar, axios) clear of advisories.Automatic notifications