Prototype store info diagnostic event sink - #8241
Draft
dmerand wants to merge 3 commits into
Draft
Conversation
Assisted-By: devx/e248984c-030c-49ff-8865-3ab7196ceb4a
Assisted-By: devx/32d44023-fc59-4089-96e8-595aca32f54c
Assisted-By: devx/64b18f05-07f8-45b3-b2d0-36667feb8a2a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a private, dependency-free
@shopify/diagnosticsleaf and a typed synchronous diagnostic side channel tostore:info. The CLI adapter connects those events to the existingdebugMessageSink, so current output and result behavior remain unchanged.Why
Shopify CLI is moving toward data-only finite execution contracts that can serve CLI, SDK, MCP, and other adapters without depending on terminal rendering. This proof of concept demonstrates the compatibility seam between renderer-first execution and future explicit result/event adapters without claiming a universal event framework.
How
store:info, with typed variants and safe error projections.Async delivery, stream/progress protocols, universal result/error/event envelopes, launcher or
BaseCommandchanges, infrastructure logging, and broader command migration are out of scope.Verification and limitations
@shopify/diagnosticsbuild, type-check, and lint pass.git diff --checkpass.storetype-check remains blocked by the pre-existing missing@shopify/organizationsdeclarations; no errors were reported in the changed diagnostics or store-info code.Post-release steps: None.