Skip to content

Prototype store info diagnostic event sink - #8241

Draft
dmerand wants to merge 3 commits into
mainfrom
donald/store-info-event-sink-poc
Draft

Prototype store info diagnostic event sink#8241
dmerand wants to merge 3 commits into
mainfrom
donald/store-info-event-sink-poc

Conversation

@dmerand

@dmerand dmerand commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What

Add a private, dependency-free @shopify/diagnostics leaf and a typed synchronous diagnostic side channel to store:info. The CLI adapter connects those events to the existing debugMessageSink, so current output and result behavior remain unchanged.

Why

Shopify CLI is moving toward data-only finite execution contracts that can serve CLI, SDK, MCP, and other adapters without depending on terminal rendering. This proof of concept demonstrates the compatibility seam between renderer-first execution and future explicit result/event adapters without claiming a universal event framework.

How

  • Keep diagnostics data-only and synchronous; observers run in registration order and observer failures do not affect command results.
  • Keep domain events owned by store:info, with typed variants and safe error projections.
  • Preserve the existing JSON wire shape, stdout/stderr separation, debug filtering, timestamps, color handling, test log collection, fallback/result/error behavior, and non-interactive behavior through the existing CLI output adapter.

Async delivery, stream/progress protocols, universal result/error/event envelopes, launcher or BaseCommand changes, infrastructure logging, and broader command migration are out of scope.

Verification and limitations

  • 55 focused tests pass.
  • @shopify/diagnostics build, type-check, and lint pass.
  • cli-kit type-check, changed-file ESLint, and git diff --check pass.
  • Full store type-check remains blocked by the pre-existing missing @shopify/organizations declarations; no errors were reported in the changed diagnostics or store-info code.

Post-release steps: None.

dmerand added 3 commits August 3, 2026 16:25
Assisted-By: devx/e248984c-030c-49ff-8865-3ab7196ceb4a
Assisted-By: devx/32d44023-fc59-4089-96e8-595aca32f54c
Assisted-By: devx/64b18f05-07f8-45b3-b2d0-36667feb8a2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant