Allow packed agent metadata in analytics - #8246
Open
isaacroldan wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/2ae47aa3-adba-4060-adf8-d3b99e6b63f3
github-actions
Bot
added
the
no-changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AI Toolkit sends packed CLI attribution through
SHOPIFY_CLI_AGENT_INFOandSHOPIFY_CLI_AGENT_IDS. The analytics allowlist currently drops both variables, while the data-warehouse model already reads them as fallbacks.What
getShopifyEnvironmentVariables().SHOPIFY_*variables excluded.Testing
pnpm vitest run packages/cli-kit/src/public/node/analytics.test.tspnpm eslint packages/cli-kit/src/private/node/analytics.ts packages/cli-kit/src/public/node/analytics.test.tspnpm nx bundle cli --skip-nx-cacheSHOPIFY_SOMETHING_KEY=123remained excluded.git diff --checkNo changeset: this only restores internal analytics collection.