Aqara FP400: Support MCD and Re-profiling - #3118
Open
hcarter-775 wants to merge 5 commits into
Open
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 73 files 540 suites 0s ⏱️ Results for commit b1b778a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 30a04ff |
hcarter-775
requested review from
NoahCornell,
ctowns,
gharveymn,
samadDotDev and
tpmanley
July 14, 2026 16:15
hcarter-775
commented
Jul 14, 2026
| end | ||
| end | ||
|
|
||
| --- Deeply compare two values. |
Contributor
Author
There was a problem hiding this comment.
since this is now being used in 2 subdrivers, I just moved this to the main utils file
hcarter-775
force-pushed
the
support/fp400-mcd-reprofiling
branch
from
July 30, 2026 17:27
30a04ff to
0b2b178
Compare
|
Profile category check: ✅ Passed - all profiles have a category defined. |
|
matter-sensor_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against b1b778a |
hcarter-775
force-pushed
the
support/fp400-mcd-reprofiling
branch
from
August 3, 2026 22:51
52a629d to
b1b778a
Compare
Contributor
|
@hdlee27 Could you share your test result? |
cjswedes
reviewed
Aug 5, 2026
| "Test profile change on endpoints increment in infoChanged for FP400", | ||
| function() | ||
| local current_profile_id = mock_device.profile.id | ||
| local incremented_matter_endpoints = matter_endpoints |
Contributor
There was a problem hiding this comment.
Suggested change
| local incremented_matter_endpoints = matter_endpoints | |
| local incremented_matter_endpoints = utils.deep_copy(matter_endpoints) |
This is modifying the table that is used in the mock_device table itself. It is also modifying it for subsequent tests.
Contributor
Author
There was a problem hiding this comment.
haha, I actually did that semi on purpose for the subsequent tests. You're right that that's pretty contrived though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Support MCD profile and endpoint-comparison re-profiling for the FP400.
The endpoint data model re-interview logic will be included in 0.62+. For hubs below this version, the infoChanged trigger will never occur, unless perhaps a software version update occurs.
Summary of Completed Tests
On-device testing completed.
Adding/removing endpoints via the Aqara app updates the FP400's endpoint model, which in turn updates the device profile. All endpoint attribute updates are properly mapped to the appropriate component.