Jacobian bugfix - #1646
Merged
Merged
Conversation
Collaborator
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sevans711
self-requested a review
August 5, 2026 18:45
Sevans711
approved these changes
Aug 5, 2026
Sevans711
left a comment
Collaborator
There was a problem hiding this comment.
Fixes look clean, fully covers the scope of the original issue, and I confirmed the regression tests fail on main but succeed on this branch. Looks ready to merge!
My only tiny suggestion (non-blocking) would be to maybe add something like "regression test for issue # 1645" to the test docstring for easy/quick future reference.
Added regression test for issue #1645 in the Jacobian summation function.
rajeeja
approved these changes
Aug 6, 2026
rajeeja
left a comment
Contributor
There was a problem hiding this comment.
Verified locally: the accumulator no longer gets clobbered, face areas are unchanged, and the new regression tests plus the rest of test_areas.py pass. The face_jacobian property fix is correct too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1645
Overview
This PR resolves incorrect Jacobian calculations, described in #1645.
The fix is fairly simple, we basically just rename the node jacobian results so they don't clobber the accumulators. I also added a regression test.
Bonus: The
Grid.face_jacobianproperty was technically unreachable due to a logic error. One-line fix.PR Checklist
General
Testing & Benchmarking