[filesystem] Fix nested META-INF/versions in filesystem impl jars - #8913
Open
sundapeng wants to merge 2 commits into
Open
[filesystem] Fix nested META-INF/versions in filesystem impl jars#8913sundapeng wants to merge 2 commits into
sundapeng wants to merge 2 commits into
Conversation
leaves12138
approved these changes
Jul 29, 2026
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I verified the nested META-INF fix and the new JarFileChecker regression protection, including the ZIP edge case without explicit directory entries. The paimon-ci-tools clean test suite also passes locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The filesystem impl modules (
paimon-oss-impl,paimon-s3-impl,paimon-azure-impl,paimon-cosn-impl,paimon-gs-impl) unpack the wholejaxb-apijar intotarget/classes/META-INF/versions/11. Sincejaxb-apiis itself a multi-release jar, its ownMETA-INFtree gets nested into the output, producing malformed entries such as:Both
ModuleUtil.classentries have the same internal class namejavax/xml/bind/ModuleUtilbut different bytecode. Any tool that scans the unpacked classes directory chokes on the duplicate. For example, JaCoCo fails with:The nesting has existed since #2658 but only surfaced after #8832 started shading
META-INF/versions/11/**frompaimon-oss-implintopaimon-jindo, propagating the malformed entries into that jar as well.Changes
META-INF/**when unzippingjaxb-apiintoMETA-INF/versions/11. The nestedMETA-INF/versions/9variants were never resolvable at runtime anyway (nested multi-release directories are not a thing), so there is no functional change. The now-unnecessaryMETA-INF/versions/11/META-INF/maven/**shade exclude is removed along with it.JarFileCheckernow rejects anyMETA-INFdirectory nested belowMETA-INF/versions/*, so a regression fails the license check CI. TheisJavaxManifestwhitelist that existed to tolerate the nested jaxb manifest is removed since the path no longer occurs.Tests
paimon-jindo: noMETA-INF/versions/11/META-INF/**entries remain and the 121META-INF/versions/11/javax/**classes are intact; JaCoCoAnalyzer.analyzeAllon the unpacked jar contents now passes (previously threw the exception above).JarFileCheckerTest#testRejectedOnNestedMetaInfInMultiReleaseDirectoryand#testAcceptedOnRegularMultiReleaseContent.