fix(rust): restore cabi_realloc for wasm32-unknown-unknown - #1677
Open
scothis wants to merge 1 commit into
Open
Conversation
`cabi_realloc` was switched to only be added for `p1` targets instead of not being added for `p2` targets. This causes modules built with `wasm32-unknown-unknown` and then enriched into a component with `wasm-tools component new` to fail. Signed-off-by: Scott Andrews <scott@andrews.me>
Contributor
Author
|
I plan to switch to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cabi_reallocwas switched to only be added forp1targets instead of not being added forp2targets in #1663. This causes modules built withwasm32-unknown-unknownand then enriched into a component withwasm-tools component newto fail.