Skip to content

configsync: skip ambiguous split sequence changes - #6086

Draft
ilyakuz-db wants to merge 2 commits into
mainfrom
configsync-skip-ambiguous-split-sequences
Draft

configsync: skip ambiguous split sequence changes#6086
ilyakuz-db wants to merge 2 commits into
mainfrom
configsync-skip-ambiguous-split-sequences

Conversation

@ilyakuz-db

Copy link
Copy Markdown
Contributor

Changes

  • detect changed sequence paths assembled from multiple YAML blocks
  • skip all changes for the affected resource atomically to avoid partial remove/add updates
  • continue syncing safe changes that do not traverse a split sequence
  • update keyed and positional split-sequence acceptance coverage

Tests

  • go test ./bundle/configsync
  • go vet ./bundle/configsync
  • ./task ws
  • shell syntax checks for updated acceptance scripts
  • git diff --check

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 07d270c

Run: 30363064781

Env 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 4 4 322 1065 6:13
💚​ aws windows 4 4 324 1063 6:25
💚​ azure linux 4 4 322 1064 5:24
💚​ azure windows 4 4 324 1062 6:46
💚​ gcp linux 1 5 321 1066 6:39
💚​ gcp windows 1 5 323 1064 4:14
8 interesting tests: 4 RECOVERED, 4 SKIP
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo 💚​R 💚​R 💚​R 💚​R 🙈​S 🙈​S
💚​ TestFetchRepositoryInfoAPI_FromRepo/root 💚​R 💚​R 💚​R 💚​R
💚​ TestFetchRepositoryInfoAPI_FromRepo/subdir 💚​R 💚​R 💚​R 💚​R
Top 6 slowest tests (at least 2 minutes):
duration env testname
5:39 azure windows TestAccept
4:13 aws windows TestAccept
3:11 gcp windows TestAccept
2:55 gcp linux TestAccept
2:51 azure linux TestAccept
2:49 aws linux TestAccept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants