feat(nuxt, nitro)!: Use convention cache ops for storage spans - #22689
Open
msonnb wants to merge 4 commits into
Open
feat(nuxt, nitro)!: Use convention cache ops for storage spans#22689msonnb wants to merge 4 commits into
msonnb wants to merge 4 commits into
Conversation
Contributor
size-limit report 📦
|
msonnb
force-pushed
the
ms/js-3105-cache-ops
branch
from
July 27, 2026 13:52
9175981 to
15c4dbe
Compare
Collapse the per-method ops onto `cache.get` / `cache.put` / `cache.remove`. The exact unstorage method is already preserved in `db.operation.name`. Ref: JS-3105 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
msonnb
force-pushed
the
ms/js-3105-cache-ops
branch
from
July 29, 2026 08:29
15c4dbe to
07fa5de
Compare
msonnb
marked this pull request as ready for review
July 29, 2026 08:43
msonnb
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 29, 2026 08:43
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7d0f2ac. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapse the ten per-method storage ops onto the three convention cache ops:
hasItem,getItem,getItemRaw,getItems,getKeyscache.getsetItem,setItemRaw,setItemscache.putremoveItem,clearcache.removedb.operation.namealready carried the exact method, so no detail is lost.The E2E tests located spans with a
findSpansByOphelper, which no longer identifies a single operation. They now usefindSpansByMethod, keyed ondb.operation.name.Part of #22446