test(e2e): Add optional SolidStart 2 E2E test - #22816
Open
s1gr1d wants to merge 2 commits into
Open
Conversation
s1gr1d
marked this pull request as draft
July 29, 2026 12:18
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
s1gr1d
marked this pull request as ready for review
July 29, 2026 13:32
nicohrubec
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copies the solidstart E2E test app and updates the version. The diff of the actual changes can be seen in the separate commit - I added a commit where the app was just copied, and a commit where the version was updated.
To properly support this version, we would need to make some changes in the SDK as it's very vinxi-oriented.
Right now, the server config is added like this through the build script:
vite build && cp src/instrument.server.ts .output/server/instrument.server.mjsMore infos on the migration: https://docs.solidjs.com/solid-start/v2/migrating-from-v1