ref(core): Use stringify helper for AI span attribute serialization - #22828
Open
nicohrubec wants to merge 1 commit into
Open
ref(core): Use stringify helper for AI span attribute serialization#22828nicohrubec wants to merge 1 commit into
stringify helper for AI span attribute serialization#22828nicohrubec wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
nicohrubec
marked this pull request as ready for review
July 29, 2026 13:44
andreiborza
approved these changes
Jul 29, 2026
Replace the manual `typeof x === 'string' ? x : JSON.stringify(x)` pattern with the `stringify` helper from `@sentry/core` across the AI integrations. The helper wraps `JSON.stringify` in a try/catch, so non-serializable values (circular references, `BigInt`) fall back to `'[unserializable]'` instead of throwing and dropping the span attributes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicohrubec
requested review from
isaacs and
mydea
and removed request for
a team
July 29, 2026 14:02
nicohrubec
force-pushed
the
ref/ai-use-stringify-helper
branch
from
July 29, 2026 14:02
c806676 to
9919f26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the manual
typeof x === 'string' ? x : JSON.stringify(x)pattern in the AI integrations with the defensivestringifyhelper so non-serializable values no longer throw and drop span attributes.