feat(core)!: Align request data collection with v11 defaults - #22853
Open
s1gr1d wants to merge 3 commits into
Open
feat(core)!: Align request data collection with v11 defaults#22853s1gr1d wants to merge 3 commits into
s1gr1d wants to merge 3 commits into
Conversation
s1gr1d
requested review from
chargome,
logaretm and
msonnb
and removed request for
a team
July 30, 2026 09:50
Contributor
size-limit report 📦
|
chargome
reviewed
Jul 30, 2026
| return undefined; | ||
| } | ||
|
|
||
| const filtered = filterQueryParams(normalized, behavior); |
Member
There was a problem hiding this comment.
Can we add an integration tests that covers this path? I think we are decoding the values in filterQueryParams (which I think is a pre-existing bug in the helper but unused in the sdk until now)
e.g.
query_string: 'q=hello%20world&token=secret'
// should result in event.request.query_string => q=hello%20world&token=[Filtered]'
Member
Author
There was a problem hiding this comment.
added an integration test and fixed this 👍
s1gr1d
requested review from
chargome,
isaacs and
mydea
and removed request for
a team
July 30, 2026 15:01
chargome
approved these changes
Jul 30, 2026
Member
There was a problem hiding this comment.
l: We can probably get rid of this test scenario or merge it with the default fetch case here now.
| return isIncluded && behavior === false ? true : behavior; | ||
| } | ||
|
|
||
| function filterQueryString(queryString: QueryParams, behavior: CollectBehavior): string | undefined { |
Member
There was a problem hiding this comment.
I think this still needs an early return on behavior === false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookies, request and response headers, and query parameters are now collected by default with sensitive values filtered, instead of being gated on
sendDefaultPii.The RequestData integration remains a second configuration layer: explicit
includevalues control whether a category is attached, whiledataCollectioncontinues to define its allowlist or denylist. Whenincludeexplicitly enables a category disabled globally, the default sensitive-value denylist applies. This also allows options such asinclude.ip: trueto overridedataCollection.userInfo: falsefor that integration.Also added tests for the different cases.
Review Tip: Use "Hide Whitespace" as there were some indentation changes.
Closes #21260