ci: 🤖 Update test matrix with new releases (07/27) - #6891
ci: 🤖 Update test matrix with new releases (07/27)#6891github-actions[bot] wants to merge 5 commits into
Conversation
Codecov Results 📊✅ 98257 passed | ❌ 41 failed | ⏭️ 7021 skipped | Total: 105319 | Pass Rate: 93.29% | Execution Time: 347m 16s 📊 Comparison with Base Branch
➕ New Tests (41)View new tests
❌ Failed Tests
|
See pallets/quart@cb4d1b6 #### Issues Closes #6901 #### Reminders - Please add tests to validate your changes, and lint your code using `uv run ruff`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
| if QUART_VERSION >= (0, 21, 0): | ||
| # Exception propagation behavior changed in 0.21.0 | ||
| await client.get("/") | ||
|
|
||
| event1, event2 = events | ||
| (event,) = events | ||
|
|
||
| (exception,) = event1["exception"]["values"] | ||
| assert exception["type"] == "ValueError" | ||
| (exception,) = event["exception"]["values"] | ||
| assert exception["type"] == "ValueError" |
There was a problem hiding this comment.
Bug: The version parsing for QUART_VERSION uses int() on version parts split by .. This will crash with a ValueError on pre-release versions like "0.21.0b1".
Severity: HIGH
Suggested Fix
Modify the version parsing logic to handle pre-release identifiers. Instead of a simple int() conversion, use a library like packaging.version.parse or manually strip non-numeric suffixes from the version components before converting them to integers. For example: from packaging.version import parse as parse_version; QUART_VERSION = parse_version(version("quart")).release.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: tests/integrations/quart/test_quart.py#L409-L416
Potential issue: The code parses the Quart version string by splitting it on `.` and
converting each part to an integer. This logic does not account for pre-release suffixes
like "a1", "b1", or "rc1". If a pre-release version of Quart is installed, such as
"0.21.0b1", the code will attempt to execute `int("0b1")`, which raises a `ValueError`.
This will cause the entire test suite to fail at module load time, preventing any tests
from running.
Update our test matrix with new releases of integrated frameworks and libraries.
How it works
Action required
🤖 This PR was automatically created using a GitHub action.