Skip to content

ref(openai-agents): Stop setting gen_ai.request.available_tools on Invoke Agent spans - #6955

Open
alexander-alderman-webb wants to merge 4 commits into
webb/openai-agents-tool-definitionsfrom
webb/openai-agents-agent-tool-definitions
Open

ref(openai-agents): Stop setting gen_ai.request.available_tools on Invoke Agent spans#6955
alexander-alderman-webb wants to merge 4 commits into
webb/openai-agents-tool-definitionsfrom
webb/openai-agents-agent-tool-definitions

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

The attribute is not well-defined for agents as an agent can make different tools available over the course of its execution.

See https://github.com/getsentry/rfcs/blob/main/text/0153-decoupling-sentrys-generative-ai-conventions-from-open-telemetry.md for details.

Issues

Reminders

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

99549 passed | ❌ 2 failed | ⏭️ 6710 skipped | Total: 106261 | Pass Rate: 93.68% | Execution Time: 357m 17s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -290
Passed Tests 📉 -220
Failed Tests 📈 +1
Skipped Tests 📉 -71

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]
    • File: tests.profiler.test_continuous_profiler

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled[non-experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.6-common
Error: AssertionError: profiler should not be running assert '6268425d1c094ae68a8351299bff7a3c' is None + where '6268425d1c094ae68a8351299bff7a3c' = get_profiler_id()

Stack Trace
tests/profiler/test_continuous_profiler.py:812: in test_continuous_profiler_auto_start_and_stop_sampled
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '6268425d1c094ae68a8351299bff7a3c' is None
E    +  where '6268425d1c094ae68a8351299bff7a3c' = get_profiler_id()

✅ Patch coverage is 100.00%. Project has 2506 uncovered lines.
❌ Project coverage is 89.88%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.89%    89.88%    -0.01%
==========================================
  Files          193       193         —
  Lines        24686     24752       +66
  Branches      8814      8860       +46
==========================================
+ Hits         22188     22246       +58
- Misses        2498      2506        +8
- Partials      1400      1417       +17

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 31, 2026 08:55
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 31, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants