Skip to content

fix(tests): Fix flake in continuous profiler tests #6958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pabloDeputter wants to merge 5 commits into
base: master
Choose a base branch
from
+12 −4
Draft

fix(tests): Fix flake in continuous profiler tests #6958

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f224107
fix(tests): Replace fixed sleep with polling for profiler auto-start-…
pabloDeputter Jul 30, 2026
6778f4a
fix(tests): Update py version handling in workflow
pabloDeputter Jul 30, 2026
ba14852
fix(tests): Reduce polling duration to earliest auto stop
pabloDeputter Jul 30, 2026
f4e6163
fix(tests): Increase polling duration back to 0.2s
pabloDeputter Jul 30, 2026
4a8f3d1
fix(tests): Remove temporary github workflow
pabloDeputter Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/profiler/test_continuous_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,8 +807,12 @@ def test_continuous_profiler_auto_start_and_stop_sampled(
assert profiler_id is not None, "profiler should be running"
profiler_ids.add(profiler_id)

# wait at least 1 cycle for the profiler to stop
time.sleep(0.2)
# Poll up to 0.2 seconds (every 10ms) for the profiler to stop
deadline = time.monotonic() + 0.2
while time.monotonic() < deadline:
if get_profiler_id() is None:
break
time.sleep(0.01)
assert get_profiler_id() is None, "profiler should not be running"

assert len(profiler_ids) == 1
Expand Down Expand Up @@ -891,8 +895,12 @@ def test_continuous_profiler_auto_start_and_stop_sampled_span_streaming(
assert profiler_id is not None, "profiler should be running"
profiler_ids.add(profiler_id)

# wait at least 1 cycle for the profiler to stop
time.sleep(0.2)
# Poll up to 0.2 seconds (every 10ms) for the profiler to stop
deadline = time.monotonic() + 0.2
while time.monotonic() < deadline:
if get_profiler_id() is None:
break
time.sleep(0.01)
assert get_profiler_id() is None, "profiler should not be running"

assert len(profiler_ids) == 1
Expand Down
Loading