Skip to content

Actions: Improve actions cache poisoning code injection wording #22266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JarLob wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −3
Open

Actions: Improve actions cache poisoning code injection wording #22266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c40fe85
Reworded the misleading 'Unprivileged'
JarLob Jul 19, 2026
caf91c9
Add change note
JarLob Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions actions/ql/src/Security/CWE-349/CachePoisoningViaCodeInjection.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* @name Cache Poisoning via low-privileged code injection
* @name Cache Poisoning via code injection
* @description The cache can be poisoned by untrusted code, leading to a cache poisoning attack.
* @kind path-problem
* @problem.severity error
Expand Down Expand Up @@ -27,5 +27,5 @@ where
check.protects(source.getNode().asExpr(), event, "code-injection")
)
select sink.getNode(), source, sink,
"Unprivileged code injection in $@, which may lead to cache poisoning ($@).", sink,
"Code injection in $@ may allow poisoning the default-branch cache (event trigger: $@).", sink,
sink.getNode().asExpr().(Expression).getRawExpression(), event, event.getName()
4 changes: 4 additions & 0 deletions actions/ql/src/change-notes/2026-07-31-cache-poisoning-code-injection-wording.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: queryMetadata
---
* The name and alert message of the `actions/cache-poisoning/code-injection` query have been reworded for clarity.
2 changes: 1 addition & 1 deletion actions/ql/test/query-tests/Security/CWE-349/CachePoisoningViaCodeInjection.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ nodes
| .github/workflows/neg_code_injection1.yml:11:17:11:48 | github.event.comment.body | semmle.label | github.event.comment.body |
subpaths
#select
| .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | Unprivileged code injection in $@, which may lead to cache poisoning ($@). | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | ${{ github.event.comment.body }} | .github/workflows/code_injection1.yml:2:3:2:15 | issue_comment | issue_comment |
| .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | Code injection in $@ may allow poisoning the default-branch cache (event trigger: $@). | .github/workflows/code_injection1.yml:11:17:11:48 | github.event.comment.body | ${{ github.event.comment.body }} | .github/workflows/code_injection1.yml:2:3:2:15 | issue_comment | issue_comment |
Loading