Narrow PR scope to observer tick error isolation; restore synchronous initial render - #371
Draft
mattcosta7 with Copilot wants to merge 2 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Remove memoization cache from relative time update
Narrow PR scope to observer tick error isolation; restore synchronous initial render
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This revision removes the previously introduced
connectedCallbackmicrotask batching and keeps only the high-value safety fix: a single element error should not abort adateObservertick for all observed elements. It also drops per-tick locale/time-zone/hour-cycle caching from this branch to avoid correctness risk and overlap with existing global Intl caching.Scope reset: restore
mainlifecycle semanticspendingElements,pendingFlush,flushPending).connectedCallback()render (this.update()).disconnectedCallback()andattributeChangedCallback()behavior to matchmain(no pending-queue coupling).Observer robustness: per-element error isolation
timeEl.update()insidedateObserver.update()so one throw does not stop remaining elements or prevent rescheduling.Tests updated to lock intended behavior
connectedCallback microtask batchingsuite.