fix: bound response read in integration catalog fetch - #3818
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: bound response read in integration catalog fetch#3818Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bounds integration catalog responses before JSON parsing to mitigate oversized-response DoS risks.
Changes:
- Uses the shared limited-response reader.
- Applies a JSON response-size ceiling.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/integrations/catalog.py |
Adds bounded catalog response reads. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Medium
Quratulain-bilal
force-pushed
the
fix/unbounded-catalog-read-integrations
branch
from
July 29, 2026 12:33
34154a6 to
769aab7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unbounded
esp.read() with
ead_response_limited() in integrations/catalog.py to prevent DoS via oversized catalog responses.