fix: add utf-8 encoding to extension and preset registry file I/O - #3834
Open
Quratulain-bilal wants to merge 1 commit into
Open
fix: add utf-8 encoding to extension and preset registry file I/O#3834Quratulain-bilal wants to merge 1 commit into
Quratulain-bilal wants to merge 1 commit into
Conversation
Both extension and preset registry read/write calls used platform-default encoding, which on Windows (cp1252/UTF-16) would corrupt UTF-8 JSON data or raise UnicodeDecodeError. Explicitly specify encoding='utf-8' to match the JSON contract. Assisted-by: opencode (autonomous)
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures extension and preset registries consistently use UTF-8 across platforms.
Changes:
- Added UTF-8 encoding to registry reads.
- Added UTF-8 encoding to registry writes.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Uses UTF-8 for preset registry I/O. |
src/specify_cli/extensions/__init__.py |
Uses UTF-8 for extension registry I/O. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit
encoding='utf-8'to extension and preset registry file I/O to prevent corruption on non-UTF-8 Windows locales.Changes
extensions/__init__.py: Addedencoding='utf-8'to registry read/writepresets/__init__.py: Addedencoding='utf-8'to registry read/write