fix: reject non-object workflow caches - #3860
Open
marcelsafin wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens workflow catalog caching against non-object JSON values.
Changes:
- Rejects non-object workflow and step cache metadata.
- Refetches invalid workflow caches and rejects invalid stale fallbacks.
- Adds regression tests for metadata and fresh-cache behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/specify_cli/workflows/catalog.py |
Validates cached metadata and catalog payload types. |
tests/test_workflows.py |
Tests invalid metadata and workflow-cache refetching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uvx ruff@0.15.0 check src tests.venv/bin/python -m pytest -q tests/test_workflows.py(821 passed).venv/bin/python -m pytest -q(6011 passed, 173 skipped)AI disclosure
GitHub Copilot helped identify edge cases and review the implementation. I reproduced the failures and validated the final change with targeted and full test suites.