fix(scripts): stop setup-tasks text mode crashing on a legacy stdout code page - #3892
Open
jawwad-ali wants to merge 1 commit into
Open
fix(scripts): stop setup-tasks text mode crashing on a legacy stdout code page#3892jawwad-ali wants to merge 1 commit into
jawwad-ali wants to merge 1 commit into
Conversation
_check_file/_check_dir hard-code U+2713/U+2717 and print() them to sys.stdout. On Windows sys.stdout falls back to the ANSI code page whenever stdout is not a console — which is every time an agent or a workflow step captures the output — and U+2713 is unencodable in cp1252, so the document listing aborted mid-report with UnicodeEncodeError. This is the byte-identical twin of the block in scripts/python/check_prerequisites.py, which I flagged in the PR for that file rather than widening its scope. Fall back to ASCII when stdout cannot encode the glyph. "[OK]"/"[FAIL]" is the rendering these markers already have in-tree: Test-FileExists in scripts/powershell/common.ps1 emits exactly those, and normalize_status_text in tests/parity_helpers.py maps the glyphs onto them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_check_file/_check_dirinscripts/python/setup_tasks.pyhard-code the U+2713 / U+2717 glyphs andprint()them tosys.stdout:On Windows
sys.stdoutfalls back to the ANSI code page whenever stdout is not a console — a pipe or a file redirect, which is exactly how an agent or a workflow step invokes these scripts. U+2713 is unencodable in cp1252, so the document listing aborts mid-report withUnicodeEncodeError.Relationship to #3890
This is the byte-identical twin of the block in
scripts/python/check_prerequisites.py. I flagged it explicitly in that PR's body rather than widening that PR's scope:This is that follow-up. The two PRs touch different source files and different test files, so they are independent and can merge in either order.
Fix
Downgrade to ASCII only when stdout cannot encode the glyph, so a UTF-8 console is unaffected:
[OK]/[FAIL]is the ASCII rendering these markers already have in this repo:scripts/powershell/common.ps1:243Write-Output " [OK] $Description"scripts/powershell/common.ps1:246Write-Output " [FAIL] $Description"tests/parity_helpers.py:130-131text.replace(" ✓ ", " [OK] ").replace(" ✗ ", " [FAIL] ")The PowerShell twin emits the ASCII form natively and the shared parity helper maps the glyphs onto it, so the suite already treats the two as equivalent output.
Breaking risk: a UTF-8-capable stdout still gets the glyphs, byte-identical to today. The only case that changes is one that previously raised and truncated the report.
Verification
PYTHONIOENCODING=cp1252) fails on unpatched source and passes with the fix. File: 1 failed → 3 passed, 14 skipped (the skips are the bash-requiring parity cases on Windows).mainbaseline captured on81bf741(0 pre-existing in scope).uvx ruff@0.15.0 check src tests→ cleanWritten with assistance from Claude Code. Bug found, reproduced, and verified by me on current
main.