Skip to content

fix(events): ignore non-UTF-8 event overrides - #3897

Open
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/events-override-utf8
Open

fix(events): ignore non-UTF-8 event overrides#3897
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/events-override-utf8

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Summary

  • treat non-UTF-8 integration event overrides like other unreadable override files
  • retain events already resolved from earlier layers instead of aborting resolution
  • add regression coverage for an invalidly encoded override

Testing

  • uvx ruff@0.15.0 check src tests
  • .venv/bin/pytest tests/integrations/test_events.py -q (105 passed)
  • .venv/bin/pytest -q (6106 passed, 176 skipped)

AI disclosure

GitHub Copilot helped identify the missing decode-error boundary and review the implementation. I reproduced the failure and validated the final change with targeted and full test suites.

Assisted-by: GitHub Copilot (model: GPT-5.6 Sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@marcelsafin
marcelsafin requested a review from mnriem as a code owner July 31, 2026 08:27
Copilot AI review requested due to automatic review settings July 31, 2026 08:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Handles unreadable event override files without discarding previously resolved events.

Changes:

  • Catches filesystem, encoding, and YAML parsing failures.
  • Adds regression coverage for a non-UTF-8 override.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/specify_cli/events.py Ignores unreadable or malformed overrides safely.
tests/integrations/test_events.py Verifies prior-layer events are retained.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants