Skip to content

chore: update test matrix to cover currently supported node versions - #3946

Open
pearigee wants to merge 3 commits into
mainfrom
pearigee-fix-ci-node-18-breakge
Open

chore: update test matrix to cover currently supported node versions#3946
pearigee wants to merge 3 commits into
mainfrom
pearigee-fix-ci-node-18-breakge

Conversation

@pearigee

Copy link
Copy Markdown
Contributor

Unit tests are currently breaking with the following error:

Run npm install --production --engine-strict --ignore-scripts --no-package-lock
npm warn config production Use `--omit=dev` instead.
npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: brace-expansion@5.0.8
npm error notsup Not compatible with your version of node/npm: brace-expansion@5.0.8
npm error notsup Required: {"node":"20 || >=22"}
npm error notsup Actual:   {"npm":"10.8.2","node":"v18.20.8"}
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2026-07-28T20_43_01_654Z-debug-0.log

We could implement an override, but I think it makes sense to simply drop the older/unsupported runtimes as a test target. This will also match the test targets in our primary repo, google-cloud-node (as of https://github.com/googleapis/google-cloud-node/pull/8993/changes).

@pearigee
pearigee requested a review from a team as a code owner July 28, 2026 22:54
@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label Bot added the size: xs Pull request size is extra small. label Jul 28, 2026
@pearigee

pearigee commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

It looks like ci.yaml has already drifted significantly from the template in synthtool. It's not clear to me yet when/if this file would ever be regenerated.

https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_library/.github/workflows/ci.yaml

@product-auto-label product-auto-label Bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant