chore: update test matrix to cover currently supported node versions - #3946
Open
pearigee wants to merge 3 commits into
Open
chore: update test matrix to cover currently supported node versions#3946pearigee wants to merge 3 commits into
pearigee wants to merge 3 commits into
Conversation
|
Warning: This pull request is touching the following templated files:
|
Contributor
Author
|
It looks like ci.yaml has already drifted significantly from the template in synthtool. It's not clear to me yet when/if this file would ever be regenerated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests are currently breaking with the following error:
We could implement an override, but I think it makes sense to simply drop the older/unsupported runtimes as a test target. This will also match the test targets in our primary repo, google-cloud-node (as of https://github.com/googleapis/google-cloud-node/pull/8993/changes).