fix(dock): close legacy tray tooltip on popup destruction

[svan71]

What changed

Close a legacy tray tooltip directly when its PluginPopup emits
aboutToDestroy.

Fixes linuxdeepin/developer-center#13616.

Root cause

Legacy tray tooltip content is owned by a plugin popup while the translucent
tooltip host is owned by dde-shell. The plugin loader correctly hides and
destroys its popup, but ShellSurfaceItemProxy.onSurfaceDestroyed is not emitted
for this teardown. TrayItemSurfacePopup therefore never closes the shared host,
leaving an empty translucent background after the text disappears.

PluginPopup.aboutToDestroy is the authoritative server-side lifecycle signal
and is emitted immediately before the popup object is deleted. Connecting the
tooltip to that signal closes the host at the correct boundary.

Impact

Legacy tray items such as Volume and Clipboard dismiss their tooltip background
correctly. Native actions such as Quick Actions and Collapse Tray are unchanged.

Validation

• Captured the complete plugin lifecycle: pointer leave, QWidget/QWindow hide,
  popup-map removal, and PluginPopupSurface destruction all completed.
• Confirmed the old ShellSurfaceItemProxy.onSurfaceDestroyed handler did not
  run for the plugin popup teardown.
• Built a clean Arch package from dde-shell 2.0.50 containing only this lifecycle
  connection.
• Live-tested Volume and Clipboard with the exact straight-down pointer exit;
  both now dismiss cleanly.
• Rebuilt without diagnostic logging and repeated the live test successfully.

Summary by Sourcery

Bug Fixes:

• Close legacy tray tooltip hosts in response to plugin popup about-to-destroy events so tooltip backgrounds no longer remain visible after content is dismissed.

[sourcery-ai]

Sorry @svan71, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: svan71

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepin-ci-robot]

Hi @svan71. Thanks for your PR. 😃

[deepin-ci-robot]

Hi @svan71. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deepin-bot]

TAG Bot

New tag: 2.0.51
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1666

[deepin-bot]

TAG Bot

New tag: 2.0.52
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1672

[svan71]

Marked ready for review and rebased onto current master.

CLA / commitlint / SPDX / cppcheck are green.

Would appreciate an /ok-to-test when convenient. Happy to adjust anything.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Connect legacy tray tooltip closure to the PluginPopup’s aboutToDestroy lifecycle signal so the shared translucent tooltip host is closed when the popup is torn down, eliminating orphaned tooltip backgrounds in the dock tray.

Sequence diagram for legacy tray tooltip closing on PluginPopup.aboutToDestroy

sequenceDiagram
    participant PluginPopup as PluginPopup_shellSurface
    participant TrayPopup as TrayItemSurfacePopup
    participant ToolTip as toolTip
    participant Host as TooltipHost

    PluginPopup->>TrayPopup: aboutToDestroy
    TrayPopup->>ToolTip: close()
    ToolTip->>Host: close()
    Host-->>PluginPopup: [tooltip host destroyed]

Loading

File-Level Changes

Change	Details	Files
Wire the legacy tray tooltip to close when its associated PluginPopup is about to be destroyed, instead of relying solely on ShellSurfaceItemProxy surface-destroy signals.	Add a Connections block bound to toolTip.shellSurface to listen for the aboutToDestroy signal from the plugin popup Invoke toolTip.close() in the onAboutToDestroy handler to tear down the tooltip host at the correct lifecycle boundary	panels/dock/tray/TrayItemSurfacePopup.qml

Assessment against linked issues

Issue	Objective	Addressed	Explanation
linuxdeepin/developer-center#13616	Ensure legacy tray tooltip hosts (TrayItemSurfacePopup) close when their associated PluginPopup is destroyed, by connecting to the shell surface's aboutToDestroy signal so the empty translucent background no longer remains.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}