fix(session): return METHOD_NOT_FOUND for unknown request methods - #3210
Open
Ranga-Prasath-22 wants to merge 2 commits into
Open
fix(session): return METHOD_NOT_FOUND for unknown request methods#3210Ranga-Prasath-22 wants to merge 2 commits into
Ranga-Prasath-22 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return JSON-RPC
-32601 METHOD_NOT_FOUNDfor request methods that are not part of the session's request schema, while preserving-32602 INVALID_PARAMSfor known methods with invalid parameters.Why
BaseSessionpreviously mapped every request-model validation failure to-32602. That made an unsupported method indistinguishable from a malformed call and caused clients to retry requests that could never succeed.Implementation
BaseSession, covering both client and server sessions and custom request unions.Validation
Fixes #3193
Resolves #1561