Fix add contact address - #1639
Open
sim6 wants to merge 4 commits into
Open
Conversation
When clicking on the map, the ClickSearchPopup opens with an 'Add contact address' option. Clicking it previously did nothing because the click event propagated to the map container, triggering onMapNormalLeftClick which reset the placingContact state, immediately destroying the PlaceContactPopup before the user could interact with it. Add @click.stop on the ClickSearchPopup button to prevent the click from bubbling up to the map's event handler. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
The /svg/core/actions/user endpoint does not exist in Nextcloud, causing a 404 when the PlaceContactPopup renders with no contact selected. Use the existing /apps/maps/contacts-avatar endpoint as the fallback icon source instead. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
Use label instead of inputLabel on NcSelect to specify the option property key used for display and filtering. inputLabel only sets the visible <label> text (accessibility), while label tells NcSelect which property of each option to use as the display value. Without it, NcSelect defaults to 'label', which does not exist on contact objects, breaking both display and search. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
sim6
force-pushed
the
fix-add-contact-address
branch
from
July 24, 2026 23:15
a950068 to
ec0d2a2
Compare
Clicks inside the button were propagating to the map, triggering onMapNormalLeftClick and opening a new ClickSearchPopup. Add @click.stop on the PlaceContactPopup button to prevent open a new ClickSearchPopup. Signed-off-by: Simó Albert i Beltran <sim6@probeta.net>
sim6
force-pushed
the
fix-add-contact-address
branch
from
July 24, 2026 23:42
ec0d2a2 to
0e7255a
Compare
Author
|
@CarlSchwan Could you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add contact addressbutton in map popup not working