Skip to content

fix(metadata): reset lastIndex of unix manual page regex before testing #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
btea wants to merge 1 commit into from
+11 −2
Closed

fix(metadata): reset lastIndex of unix manual page regex before testing #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/unix-manual-regex-lastindex.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@node-core/doc-kit': patch
---

Fix `isTextWithUnixManual` intermittently missing valid Unix manual page
references: the shared `unixManualPage` regex is global, so its `lastIndex`
persisted between `.test()` calls during tree traversal.
6 changes: 4 additions & 2 deletions src/utils/queries/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ export const UNIST = {
* @param {import('@types/mdast').Text} text
* @returns {boolean}
*/
isTextWithUnixManual: ({ type, value }) =>
type === 'text' && QUERIES.unixManualPage.test(value),
isTextWithUnixManual: ({ type, value }) => {
QUERIES.unixManualPage.lastIndex = 0; // Reset the lastIndex to ensure proper matching
return type === 'text' && QUERIES.unixManualPage.test(value);
},
Comment thread
btea marked this conversation as resolved.

/**
* @param {import('@types/mdast').Link} link
Expand Down
Loading