Skip to content

refactor(legacy): extract @doc-kittens/legacy package - #960

Open
avivkeller wants to merge 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten
Open

refactor(legacy): extract @doc-kittens/legacy package#960
avivkeller wants to merge 1 commit into
refactor/react-kittenfrom
refactor/legacy-kitten

Conversation

@avivkeller

@avivkeller avivkeller commented Jul 30, 2026

Copy link
Copy Markdown
Member

The legacy-format generators (legacy-html, legacy-html-all, legacy-json, and legacy-json-all) have moved into the new @doc-kittens/legacy package, and are loaded via import specifiers such as @doc-kittens/legacy/legacy-html.

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Jul 30, 2026 9:31pm

Request Review

@avivkeller
avivkeller marked this pull request as ready for review July 30, 2026 21:34
@avivkeller
avivkeller requested a review from a team as a code owner July 30, 2026 21:34
Copilot AI review requested due to automatic review settings July 30, 2026 21:34
@cursor

cursor Bot commented Jul 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Breaking for direct @node-core/doc-kit/legacy-* imports and a large cross-package move; CLI names are preserved but generator loading and dependency wiring must stay correct at publish time.

Overview
Moves the legacy-html, legacy-html-all, legacy-json, and legacy-json-all generators out of @node-core/doc-kit into a new @doc-kittens/legacy workspace package, with subpath exports such as @doc-kittens/legacy/legacy-html.

CLI and config shorthand (legacy-html, etc.) still resolve through publicGenerators, but now target the new package instead of core exports. @node-core/doc-kit drops the four ./legacy-* package exports; consumers that imported those paths must switch to @doc-kittens/legacy/....

Moved code now depends on core via @node-core/doc-kit/... imports (config, remark, metadata types, etc.). legacyToJSON and its tests move from core utils into packages/legacy; core’s generators.test.mjs no longer covers it. dependsOn for the -all generators and ESLint’s browser-globals path are updated for the new layout. Changeset marks @doc-kittens/legacy major and @node-core/doc-kit minor.

Reviewed by Cursor Bugbot for commit 9d9d060. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants