doc: report proper return type on url.format - #64806
Merged
Merged
Conversation
nodejs-github-bot
added
doc
Renegade334
reviewed
Jul 28, 2026
bmuenzenmeyer
force-pushed
the
url-return-string
branch
from
July 28, 2026 14:15
33d6122 to
9f6f1ce
Compare
avivkeller
reviewed
Jul 28, 2026
bjohansebas
approved these changes
Jul 28, 2026
mertcanaltin
approved these changes
Jul 28, 2026
lpinca
approved these changes
Jul 28, 2026
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Co-authored-by: Aviv Keller <me@aviv.sh>
bmuenzenmeyer
force-pushed
the
url-return-string
branch
from
July 29, 2026 01:53
3e207b5 to
a1fc980
Compare
Renegade334
approved these changes
Jul 29, 2026
Renegade334
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3f2f10a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derived from nodejs/doc-kit#953
Verified with local doc-kit run