Skip to content

fix: handle non-IANA HTTP status codes without crashing #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adeev-mardia wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: handle non-IANA HTTP status codes without crashing #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f82a08b
fix: handle non-IANA HTTP status codes in generated clients
adeev-mardia Jul 28, 2026
0f8c7f8
fix: handle non-IANA HTTP status codes in generated clients
adeev-mardia Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions openapi_python_client/templates/endpoint_module.py.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def _get_kwargs(
{% if endpoint.path_parameters %}
"url": "{{ endpoint.path }}".format(
{%- for parameter in endpoint.path_parameters -%}
{{parameter.python_name}}=quote(str({{parameter.python_name}}), safe=""),
{{parameter.python_name}}=\quote(str({{parameter.python_name}}), safe=\"\"),
{%- endfor -%}
),
{% else %}
Expand Down Expand Up @@ -99,8 +99,12 @@ def _parse_response(*, client: AuthenticatedClient | Client, response: httpx.Res


def _build_response(*, client: AuthenticatedClient | Client, response: httpx.Response) -> Response[{{ return_string }}]:
try:
status_code = HTTPStatus(response.status_code)
except ValueError:
status_code = response.status_code
return Response(
status_code=HTTPStatus(response.status_code),
status_code=status_code,
content=response.content,
headers=response.headers,
parsed=_parse_response(client=client, response=response),
Expand Down
2 changes: 1 addition & 1 deletion openapi_python_client/templates/types.py.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ T = TypeVar("T")
class Response(Generic[T]):
""" A response from an endpoint """

status_code: HTTPStatus
status_code: HTTPStatus | int
content: bytes
headers: MutableMapping[str, str]
parsed: T | None
Expand Down