[release-4.20] OCPBUGS-104530: Re-enable-knative

[cajieh]

Analysis / Root cause:
Knative Cypress e2e was disabled under OCPBUGS-99226 (#16782) because knative-ci.feature was flaking in CI. Failures commonly hit the beforeEach → cy.initAdmin() path when the perspective switcher was not ready yet (timeout on perspective-switcher-toggle / menu interaction), which blocked unrelated PRs.

The harness was also using fixed cy.wait() delays around perspective menu open, which is brittle under React 18 / CI load.

Solution description:
Re-enable Knative Cypress suites and harden shared perspective-switcher helpers:

1. Re-enable Knative runs in:
   • frontend/integration-tests/test-cypress.sh (test-cypress-knative-nightly, test-cypress-knative-headless)
   • test-prow-e2e.sh (SCENARIO == knative)
2. In initAdmin / initDeveloper, wait for perspective-switcher-toggle to exist and be visible (60s) before switching perspective.
3. In nav.ts perspective switcher helpers:
   • Increase menu aria-expanded wait where needed
   • Replace fixed cy.wait(1000/1500) with waiting for perspective-switcher-menu-option visibility
   • Use a normal .click() (no force: true) once the option is visible

No product UI changes; test harness / CI wiring only.

Screenshots / screen recording:
N/A — CI / Cypress harness change only.

Test setup:

• Cluster with Knative / Serverless available (same as existing knative Cypress jobs)
• Local (optional): from frontend/, run knative headless suite via ./integration-tests/test-cypress.sh -p knative -h true against a configured bridge/cluster
• CI: confirm knative scenario / nightly + headless jobs run and are green on this PR

Test cases:

1. Knative prow scenario (SCENARIO=knative) executes (no longer skipped/commented out).
2. Nightly / headless Cypress aggregators invoke knative suites again.
3. Knative beforeEach / initAdmin no longer times out waiting for perspective switcher under CI load.
4. Switching to Core platform and Developer perspectives succeeds without forced clicks or fixed sleeps.
5. knative-ci.feature smoke scenarios pass (create / interact with knative service & revision as covered by the suite).
6. Unrelated Cypress packages that use initAdmin / initDeveloper still pass (shared harness change).

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

N/A for merge gate (CI Cypress / Chrome-like headless). Mark browsers only if manually exercised locally.

Additional info:

• Closes / tracks: https://issues.redhat.com/browse/OCPBUGS-99292
• Related disable: OCPBUGS-99226 (OCPBUGS-99226: Disable Knative e2e cypress test #16782)
• Shared harness impact: admin.ts / nav.ts changes affect all Cypress suites using initAdmin / initDeveloper, not only knative.
• Release branches disabled under OCPBUGS-99226 should be re-enabled or explicitly waived after main is stable.
• Merge recommendation: wait for green knative CI on this PR before considering the flake fixed.

Reviewers and assignees:
/assign

Summary by CodeRabbit

• Tests
  • Enabled Knative Cypress suites for both nightly and headless runs.
  • Re-enabled Knative Cypress execution when the end-to-end scenario is set to Knative.
  • Improved reliability of perspective-switching tests by replacing fixed waits with UI readiness checks (waiting for the correct legacy toggle and menu options to become visible before interacting).

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 37063256-14b2-40d2-a7c8-cce7cb8bc6a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-104530, which is invalid:

• expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.0" instead
• expected Jira Issue OCPBUGS-104530 to depend on a bug targeting a version in 4.21.0, 4.21.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:
Knative Cypress e2e was disabled under OCPBUGS-99226 (#16782) because knative-ci.feature was flaking in CI. Failures commonly hit the beforeEach → cy.initAdmin() path when the perspective switcher was not ready yet (timeout on perspective-switcher-toggle / menu interaction), which blocked unrelated PRs.

The harness was also using fixed cy.wait() delays around perspective menu open, which is brittle under React 18 / CI load.

Solution description:
Re-enable Knative Cypress suites and harden shared perspective-switcher helpers:

1. Re-enable Knative runs in:

• frontend/integration-tests/test-cypress.sh (test-cypress-knative-nightly, test-cypress-knative-headless)
• test-prow-e2e.sh (SCENARIO == knative)

2. In initAdmin / initDeveloper, wait for perspective-switcher-toggle to exist and be visible (60s) before switching perspective.
3. In nav.ts perspective switcher helpers:

• Increase menu aria-expanded wait where needed
• Replace fixed cy.wait(1000/1500) with waiting for perspective-switcher-menu-option visibility
• Use a normal .click() (no force: true) once the option is visible

No product UI changes; test harness / CI wiring only.

Screenshots / screen recording:
N/A — CI / Cypress harness change only.

Test setup:

• Cluster with Knative / Serverless available (same as existing knative Cypress jobs)
• Local (optional): from frontend/, run knative headless suite via ./integration-tests/test-cypress.sh -p knative -h true against a configured bridge/cluster
• CI: confirm knative scenario / nightly + headless jobs run and are green on this PR

Test cases:

1. Knative prow scenario (SCENARIO=knative) executes (no longer skipped/commented out).
2. Nightly / headless Cypress aggregators invoke knative suites again.
3. Knative beforeEach / initAdmin no longer times out waiting for perspective switcher under CI load.
4. Switching to Core platform and Developer perspectives succeeds without forced clicks or fixed sleeps.
5. knative-ci.feature smoke scenarios pass (create / interact with knative service & revision as covered by the suite).
6. Unrelated Cypress packages that use initAdmin / initDeveloper still pass (shared harness change).

Browser conformance:

• Chrome
• Firefox
• Safari (or Epiphany on Linux)

N/A for merge gate (CI Cypress / Chrome-like headless). Mark browsers only if manually exercised locally.

Additional info:

• Closes / tracks: https://issues.redhat.com/browse/OCPBUGS-99292
• Related disable: OCPBUGS-99226 (OCPBUGS-99226: Disable Knative e2e cypress test #16782)
• Shared harness impact: admin.ts / nav.ts changes affect all Cypress suites using initAdmin / initDeveloper, not only knative.
• Release branches disabled under OCPBUGS-99226 should be re-enabled or explicitly waived after main is stable.
• Merge recommendation: wait for green knative CI on this PR before considering the flake fixed.

Reviewers and assignees:
/assign

Summary by CodeRabbit

• Tests
• Enabled Knative Cypress suites for both nightly and headless runs.
• Re-enabled Knative Cypress execution when the end-to-end scenario is set to Knative.
• Improved reliability of perspective-switching tests by replacing fixed waits with UI readiness checks (waiting for the correct legacy toggle and menu options to become visible before interacting).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[cajieh]

/jira refresh

[openshift-ci-robot]

@cajieh: This pull request references Jira Issue OCPBUGS-104530, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-100377 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-100377 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0, 4.21.z
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/approve
/label backport-risk-assessed
/lgtm
/verified by CI

[openshift-ci-robot]

@rhamilto: This PR has been marked as verified by CI.

Details

In response to this:

/approve
/label backport-risk-assessed
/lgtm
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/test e2e-gcp-console

[rhamilto]

/test e2e-gcp-console

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 21b2706 and 2 for PR HEAD f0cb693 in total

[openshift-ci]

@cajieh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	f0cb693	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.