[GR-77959] Cache utf8 bytes in native. - #1050
Closed
graalvmbot wants to merge 2 commits into
Closed
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already did caching of UTF-8 bytes once they were requested but our approach was a bit too heavy since we created a bytes object holding the UTF-8 data and forced the storage to native.
Now, I'm storing (just as CPython) the bytes in a native buffer and can so use it (if available) without an upcall.
Further, we now also make use of the fact that pure ASCII codepoints can also be reused without any transcoding.