fix RangeSlider allow_cross - #3926
Open
Sasha-P wants to merge 1 commit into
Open
Conversation
Sasha-P
requested review from
KoolADE85,
T4rk1n,
camdecoster and
ndrezn
as code owners
July 29, 2026 20:23
|
Contributor
|
Thanks for the PR! Could you please add some examples of the issues with screenshots and/or videos? This is a lot of code to review and the examples would help us target our review. |
Author
|
@camdecoster description updated. added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fix RangeSlider crossing and interaction synchronization
Summary
This PR fixes
dcc.RangeSliderinteraction regressions aroundallowCross,updatemode, direct input, and thumb identity.allowCross=Falseconsistently for pointer, keyboard, Home/End, anddirect-input changes.
allowCross=Truewhen the prop isomitted, while publishing crossed values in canonical ascending order.
drag_valuelive duringupdatemode="mouseup"interactions and publishvalueonly when the interaction commits.clicks, and mixed pointer/keyboard input.
external
valueupdate arrives, including when the number of handles changes.valueanddrag_valueafter direct-input blur, including whenthe constrained result returns to the interaction's starting value.
No public API is added or removed. The changes make the existing
allowCrossand
updatemodecontracts behave consistently across all input methods.Steps to reproduce
example.py
From the workspace root, check out the parent revision and start the manual
RangeSlider app:
Open http://127.0.0.1:8050 and find the
RangeSlider allowCross=False updatemode=dragexample.Drag the lower handle past the upper handle.
Before this fix, the lower handle crosses the upper handle even though
allowCross=False, and the callback value changes from[5, 15]to acrossed range such as
[15, 18].Stop the server, check out this commit, and repeat the same interaction:
After this fix, the lower handle stops at the upper handle and the callback
value remains constrained, for example
[15, 15].Before and after recording
The left panel is the parent revision (
3d3a9f70f); the right panel is thiscommit (
41cd7f87f). Both panels replay the same pointer path withallowCross=False.Implementation notes
mouseupcommits use the interaction's authoritative start and final values.cross or become equal.
resolution for duplicate values, horizontal/vertical orientation, and
reversed sliders.
updating disabled sliders.
setPropsupdates aredistinguished from same-value authoritative external updates.
publish constrained, canonical values at the correct update boundary.
Test coverage
Added a focused 15-test Firefox integration suite covering:
allowCross;dragandmouseupupdate modes;drag_valueresynchronization after direct-input blur.The existing keyboard-input test now sets
allowCross=Falseexplicitly where itasserts no-cross behavior.
Verification
Additional checks:
countwarning)git diff --check: passedmanual_rangeslider_allow_cross.py: passedContributor Checklist
this PR.
Optionals
CHANGELOG.md.