fix(Autofocus): guard depthPickingPass/copyPass against double dispose - #354
Open
kvvasuu wants to merge 1 commit into
Open
fix(Autofocus): guard depthPickingPass/copyPass against double dispose#354kvvasuu wants to merge 1 commit into
kvvasuu wants to merge 1 commit into
Conversation
EffectComposerImpl.dispose() disposes every pass it holds, including these two added via composer.addPass - if Autofocus unmounts alongside its ancestor EffectComposer, its own cleanup disposed them a second time. This collision only becomes reachable now that the composer lifecycle fix (previous commit) actually disposes the composer on unmount - previously it leaked and never disposed at all, so it never collided with Autofocus's own cleanup.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EffectComposerImpl.dispose() disposes every pass it holds, including these two added via composer.addPass - if Autofocus unmounts alongside its ancestor EffectComposer, its own cleanup disposed them a second time. This collision only becomes reachable now that the composer lifecycle fix (previous commit) actually disposes the composer on unmount - previously it leaked and never disposed at all, so it never collided with Autofocus's own cleanup.