gh-94543: Clarify the mkstemp documentation - #107033
Closed
picnic-sven wants to merge 1 commit into
Closed
Conversation
Comment on lines
+225
to
+227
| Unlike :func:`TemporaryFile`, the user of :func:`mkstemp` is responsible for closing | ||
| and deleting the temporary file (by e.g. using :func:`os.close` and | ||
| :func:`os.remove`) when done with it. |
Member
There was a problem hiding this comment.
- Please ensure lines are max 79 characters.
- Please don't use latin abbreviations, see the devguide for more information.
|
This PR is stale because it has been open for 30 days with no activity. |
|
|
||
| Unlike :func:`TemporaryFile`, the user of :func:`mkstemp` is responsible | ||
| for deleting the temporary file when done with it. | ||
| Unlike :func:`TemporaryFile`, the user of :func:`mkstemp` is responsible for closing |
Member
There was a problem hiding this comment.
"for closing the file descriptor and deleting the temporary file"
github-actions
Bot
removed
the
stale
Member
|
Thanks for the PR, closed in favour of #154748 which includes this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the
mkstempdocumentation to explicity describe that the file should be closed and removed.Originally raised in: #94543
tempfile.mkstemp#94543📚 Documentation preview 📚: https://cpython-previews--107033.org.readthedocs.build/