gh-155059: Add the *delimiters* parameter in the csv.Sniffer constructor - #155060
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-155059: Add the *delimiters* parameter in the csv.Sniffer constructor#155060serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
…tructor It is used by both sniff() and has_header(), and its characters are preferred, in the given order, for breaking ties.
Documentation build overview
5 files changed ·
|
dolfinus
reviewed
Aug 3, 2026
| def __init__(self): | ||
| # in case there is more than one possible delimiter | ||
| self.preferred = [',', '\t', ';', ' ', ':'] | ||
| def __init__(self, delimiters=None): |
There was a problem hiding this comment.
Can we use keyword-only arguments here? csv.Sniffer(delimiters=",;") is more readable than csv.Sniffer(",;")
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
csv.Snifferconstructor now accepts an optional delimiters argument, used by bothsniff()andhas_header(), which previously had no way to restrict the delimiters. The delimiters argument ofsniff()still takes precedence.The given delimiters are also preferred in that order for breaking ties:
csv.Sniffer(';,')guesses';'wherecsv.Sniffer(',;')guesses','.