Move trailing-comma config tests to check tests - #21786
Open
YingqiDuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5966.
This is a test-only change that moves multiline trailing-comma coverage from three subprocess-based
cmdline.testcases into existingcheck-flags.testcases:testCmdlineCfgEnableErrorCodeTrailingComma->testPerModuleErrorCodesOverridetestCmdlineCfgDisableErrorCodeTrailingComma->testDisableErrorCodeConfigFiletestCmdlineCfgAlwaysTrueTrailingComma->testAlwaysTrueAlwaysFalseConfigFileThe existing check cases exercise the configured behavior, so the command-line cases can be removed without losing coverage. In
testPerModuleErrorCodesOverride,truthy-boolis placed last so the value immediately before the trailing comma is exercised by the test.Tests:
python -m pytest -n0 -q mypy/test/testcheck.py::TypeCheckSuite::check-flags.test(219 passed)python -m pytest -n0 -q mypy/test/testcmdline.py -k "testCmdlineCfgFilesTrailingComma or testCmdlineCfgModulesTrailingComma or testCmdlineCfgPackagesTrailingComma"(3 passed)Local targeted timing on Windows with pytest parallelism disabled (
-n0), averaged across three runs:cmdline.testcases: 9.08scheck-flags.testcases: 0.54s