Skip to content

Fix tkinter.OptionMenu callback type #16113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subotac wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Fix tkinter.OptionMenu callback type #16113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stdlib/@tests/test_cases/check_tkinter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ def foo(x: int, y: str) -> None:
root.after(1000, foo, 10, "lol")
root.after(1000, foo, 10, 10) # type: ignore

tkinter.OptionMenu(root, tkinter.StringVar(), "option", command=lambda value: assert_type(value, str))

@srittau srittau Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since our tests are never run, they are only checked against type checkers, this test doesn't do much. We try to keep our tests minimal, so this isn't needed.



# Font size must be integer
label = tkinter.Label()
Expand Down
4 changes: 2 additions & 2 deletions stdlib/tkinter/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3905,7 +3905,7 @@ class OptionMenu(Menubutton):
variable: StringVar,
value: str,
*values: str,
command: Callable[[StringVar], object] | None = ...,
command: Callable[[str], object] | None = ...,
name: str | None = None,
) -> None: ...
else:
Expand All @@ -3916,7 +3916,7 @@ class OptionMenu(Menubutton):
variable: StringVar,
value: str,
*values: str,
command: Callable[[StringVar], object] | None = ...,
command: Callable[[str], object] | None = ...,
) -> None: ...
# configure, config, cget are inherited from Menubutton
# destroy and __getitem__ are overridden, signature does not change
Expand Down