Skip to content

refactor: establish Crypto folder feature #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
Open

refactor: establish Crypto folder feature #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"WebAPI.File": ["WebAPI.Event", "File"],
"WebAPI.URL": ["WebAPI.DOM", "URL"],
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
"WebAPI.Crypto": ["WebAPI.DOM", "Crypto"],

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Make the advertised Crypto feature compile

When a consumer selects WebAPI.Crypto, rescript build --prod --features WebAPI.Crypto fails because this implication activates the entire WebAPI.DOM source group, while its dependencies do not provide modules such as EventTarget and DOMStringMap used by that group. The compiler help confirms that --features includes transitively implied features, so the new public feature is unusable unless this dependency points at the appropriate internal foundation or supplies the complete DOM prerequisite closure.

Useful? React with 👍 / 👎.

"WebAPI.Performance": ["WebAPI.Event", "Performance"],
"WebAPI.ViewTransitions": ["WebAPI.Event", "ViewTransitions"]
},
Expand Down Expand Up @@ -536,9 +537,9 @@
]
},
{
"dir": "src/WebCrypto",
"dir": "src/crypto",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the docs feature map for the renamed folder

After this rename, scripts/unmonorepo/feature-spec.mjs still describes the feature directory as WebCrypto. Consequently, docs/utils.js searches for src/WebCrypto/WebCryptoTypes.res and filters the API module out when that path does not exist, so the Crypto documentation disappears from the generated API pages. Update the shared feature specification to recognize the new directory while retaining the intended public naming.

Useful? React with 👍 / 👎.

"subdirs": true,
"feature": "WebAPI.WebCrypto",
"feature": "Crypto",
"public": [
"Crypto",
"SubtleCrypto"
Expand Down
0 src/WebCrypto/Crypto.res → src/crypto/Crypto.res
View file
Open in desktop
File renamed without changes.
0 src/WebCrypto/SubtleCrypto.res → src/crypto/SubtleCrypto.res
View file
Open in desktop
File renamed without changes.
0 src/WebCrypto/WebCryptoTypes.res → src/crypto/WebCryptoTypes.res
View file
Open in desktop
File renamed without changes.