refactor: consolidate Messaging folder feature - #322
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e2ffcefe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/ChannelMessaging", | ||
| "dir": "src/messaging", |
There was a problem hiding this comment.
Keep the moved messaging modules in the API docs
When Astro generates the API reference, docs/utils.js:85-92 derives each source directory from featureSpecs, which still lists ChannelMessaging, Notification, Push, and WebSockets (scripts/unmonorepo/feature-spec.mjs:77,95,99,113). After moving those files into src/messaging, none of their expected *Types.res paths exist, so the filter silently drops all four API groups and their public modules—including MessagePort, Notification, the Push modules, and WebSocket—from the generated routes and index. Update the documentation metadata/path handling as part of this move.
Useful? React with 👍 / 👎.
f0e2ffc to
ffb7185
Compare
Tracking issue: #342
Stack context
Part 12 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #321.
Summary
src/messagingfolder on the unqualified internalMessagingfeatureWebAPI.MessagingbundleWebAPI.Messaging -> WebAPI.Event + WebAPI.File + MessagingTemporary state
*Typeshelpers remain inside the correct folder pending final cleanupReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,File,Messagingnpm run buildnpm testnpm run format:checkgit diff --check