Skip to content

refactor: consolidate Messaging folder feature - #322

Open
jderochervlk wants to merge 1 commit into
codex/option5-device-folderfrom
codex/option5-messaging-folder
Open

refactor: consolidate Messaging folder feature#322
jderochervlk wants to merge 1 commit into
codex/option5-device-folderfrom
codex/option5-messaging-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 12 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #321.

Summary

  • add the target src/messaging folder on the unqualified internal Messaging feature
  • merge channel messaging, notifications, push, and WebSockets into that complete folder
  • replace four qualified source features with the supported WebAPI.Messaging bundle
  • define WebAPI.Messaging -> WebAPI.Event + WebAPI.File + Messaging
  • preserve all existing flat public interface modules

Temporary state

  • this PR introduces no exclusions, compatibility aliases, or module slices; the Messaging folder membership and public implication are final
  • its private domain *Types helpers remain inside the correct folder pending final cleanup
  • Service Worker interfaces are intentionally not included here; they move into Workers after the Storage dependency is established

Review focus

  • the coarse Messaging bundle membership
  • removal of the former ChannelMessaging, Notification, Push, and WebSockets consumer features
  • preservation of public module paths and signatures

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,File,Messaging
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0e2ffcefe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
},
{
"dir": "src/ChannelMessaging",
"dir": "src/messaging",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the moved messaging modules in the API docs

When Astro generates the API reference, docs/utils.js:85-92 derives each source directory from featureSpecs, which still lists ChannelMessaging, Notification, Push, and WebSockets (scripts/unmonorepo/feature-spec.mjs:77,95,99,113). After moving those files into src/messaging, none of their expected *Types.res paths exist, so the filter silently drops all four API groups and their public modules—including MessagePort, Notification, the Push modules, and WebSocket—from the generated routes and index. Update the documentation metadata/path handling as part of this move.

Useful? React with 👍 / 👎.

@jderochervlk
jderochervlk force-pushed the codex/option5-messaging-folder branch from f0e2ffc to ffb7185 Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant