Skip to content

refactor: establish Animation folder feature #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
Open

refactor: establish Animation folder feature #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"WebAPI.DOM": ["DOM"],
"WebAPI.Event": ["WebAPI.DOM", "Event"],
"WebAPI.DOMPlatform": ["WebAPI.Event", "DOMPlatform"],
"WebAPI.Animation": ["WebAPI.Event", "Animation"],
"WebAPI.File": ["WebAPI.Event", "File"],
"WebAPI.URL": ["WebAPI.DOM", "URL"],
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
Expand Down Expand Up @@ -35,6 +36,16 @@
"DOMTokenList"
]
},
{
"dir": "src/animation",
"subdirs": true,
"feature": "Animation",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include animation modules in DOM's feature closure

When a consumer selects WebAPI.DOM but omits the new WebAPI.Animation, rescript build --features excludes this tagged directory—as the CLI help specifies for directories outside the selected or implied features—while still compiling src/DOM/Element.res, Document.res, and ShadowRoot.res, which reference Animation and AnimationEffect. I confirmed this by building with every source feature except Animation; compilation fails at Element.res:32 because Animation cannot be found. Keep these bindings in DOM's closure or move/gate every DOM module that depends on them.

Useful? React with 👍 / 👎.

"public": [
"Animation",
"AnimationEffect",
"DocumentTimeline"
]
},
{
"dir": "src/css-font-loading",
"subdirs": true,
Expand Down Expand Up @@ -101,8 +112,6 @@
"subdirs": true,
"feature": "WebAPI.DOM",
"public": [
"Animation",
"AnimationEffect",
"CSSRuleList",
"CSSStyleDeclaration",
"StyleSheet",
Expand All @@ -122,7 +131,6 @@
"DOMTree",
"Document",
"DocumentFragment",
"DocumentTimeline",
"DomHTMLMediaElement",
"Element",
"ElementInternals",
Expand Down
0 src/DOM/Animation.res → src/animation/Animation.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/AnimationEffect.res → src/animation/AnimationEffect.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/DocumentTimeline.res → src/animation/DocumentTimeline.res
View file
Open in desktop
File renamed without changes.