Skip to content

refactor: establish CSSOM folder feature - #325

Open
jderochervlk wants to merge 1 commit into
codex/option5-geometry-folderfrom
codex/option5-cssom-folder
Open

refactor: establish CSSOM folder feature#325
jderochervlk wants to merge 1 commit into
codex/option5-geometry-folderfrom
codex/option5-cssom-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 15 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #324.

Summary

  • add the target src/cssom folder on the unqualified internal CSSOM feature
  • move stylesheet, CSS declaration/value, media-query, and style-property-map interfaces out of the legacy DOM folder
  • add the supported WebAPI.CSSOM feature
  • preserve all nine flat public interface module paths and binding signatures

Dependency direction

The proposal had CSSOM imply DOMNodes. The compiler graph shows the opposite direction:

  • CSSOM itself needs only the Event foundation, through MediaQueryList
  • DOMTree and Element reference CSSOM-owned types
  • making CSSOM imply DOMNodes would therefore create a cycle

This layer defines WebAPI.CSSOM -> WebAPI.Event + CSSOM. The DOMNodes layer will imply CSSOM.

Temporary state

  • several CSSOM modules still expose shared records rooted in earlier compatibility types; final type ownership cleanup remains deferred
  • this PR introduces no file exclusions or module slices

Review focus

  • the compiler-derived acyclic dependency direction
  • complete CSSOM folder membership
  • unchanged flat public modules

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,CSSOM
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: cc0bb1f0d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-cssom-folder branch from cc0bb1f to c7324a1 Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant