refactor: establish CSSOM folder feature - #325
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-cssom-folder
branch
from
August 4, 2026 17:31
cc0bb1f to
c7324a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 15 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #324.
Summary
src/cssomfolder on the unqualified internalCSSOMfeatureWebAPI.CSSOMfeatureDependency direction
The proposal had CSSOM imply DOMNodes. The compiler graph shows the opposite direction:
MediaQueryListDOMTreeandElementreference CSSOM-owned typesThis layer defines
WebAPI.CSSOM -> WebAPI.Event + CSSOM. The DOMNodes layer will imply CSSOM.Temporary state
Review focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,CSSOMnpm run buildnpm testnpm run format:checkgit diff --check