Skip to content

refactor: establish DOMNodes folder feature #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
Open

refactor: establish DOMNodes folder feature #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 39 additions & 20 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@
"WebAPI.Animation": ["WebAPI.Event", "Animation"],
"WebAPI.Geometry": ["WebAPI.DOM", "Geometry"],
"WebAPI.CSSOM": ["WebAPI.Event", "CSSOM"],
"WebAPI.DOMNodes": [
"WebAPI.DOMPlatform",
"WebAPI.Animation",
"WebAPI.CSSOM",
"WebAPI.Geometry",
"DOMNodes"
],
"WebAPI.File": ["WebAPI.Event", "File"],
"WebAPI.URL": ["WebAPI.DOM", "URL"],
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
Expand Down Expand Up @@ -38,6 +45,38 @@
"DOMTokenList"
]
},
{
"dir": "src/dom-nodes",
"subdirs": true,
"feature": "DOMNodes",
Comment on lines +49 to +51

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve DOMNodes in the WebAPI.DOM feature closure

When a consumer enables WebAPI.DOM—or another feature such as WebAPI.Event that depends on it—the feature closure still contains only DOM, while the selected src/DOM sources continue to import modules moved behind DOMNodes (for example, Document.res imports Node, DOMTree, HTMLCollection, Range, and Selection). Those selective builds can therefore no longer resolve the moved modules; the split needs to preserve these dependencies in the existing feature closure or wait until the remaining DOM consumers move as well.

Useful? React with 👍 / 👎.

"public": [
"AbstractRange",
Comment on lines +52 to +53

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Register the new source directory with the docs generator

Running npm run build:docs invokes prebuild:docs, whose docs/llm.js looks up every public source directory in scripts/unmonorepo/feature-spec.mjs and throws Unsupported source directory when no matching dirName exists. That table has DOM but no dom-nodes, so encountering any of these newly public files makes the documentation build fail; add metadata for this directory or make the generator derive it from rescript.json.

Useful? React with 👍 / 👎.

"Attr",
"CaretPosition",
"CDATASection",
"CharacterData",
"Comment",
"DOMImplementation",
"DOMTree",
"DocumentFragment",
"Element",
"ElementInternals",
"HTML",
"HTMLCollection",
"NamedNodeMap",
"Node",
"NodeFilter",
"NodeIterator",
"NodeList",
"ProcessingInstruction",
"Range",
"Selection",
"ShadowRoot",
"StaticRange",
"Text",
"TreeWalker"
]
},
{
"dir": "src/animation",
"subdirs": true,
Expand Down Expand Up @@ -144,31 +183,21 @@
"subdirs": true,
"feature": "WebAPI.DOM",
"public": [
"CaretPosition",
"CharacterData",
"Comment",
"CustomElementRegistry",
"DOMImplementation",
"DOMTree",
"Document",
"DocumentFragment",
"DomHTMLMediaElement",
"Element",
"ElementInternals",
"HTMLAnchorElement",
"HTMLAreaElement",
"HTMLAudioElement",
"HTMLBRElement",
"HTMLBaseElement",
"HTMLBodyElement",
"HTMLButtonElement",
"HTMLCollection",
"HTMLDListElement",
"HTMLDataElement",
"HTMLDataListElement",
"HTMLDialogElement",
"HTMLDivElement",
"HTML",
"HTMLElement",
"HTMLEmbedElement",
"HTMLFieldSetElement",
Expand Down Expand Up @@ -223,23 +252,13 @@
"IdleDeadline",
"ImageData",
"Location",
"NamedNodeMap",
"Navigator",
"Node",
"NodeFilter",
"NodeIterator",
"NodeList",
"Range",
"SVGElement",
"SVGGraphicsElement",
"SVGLength",
"ScreenOrientation",
"Selection",
"ShadowRoot",
"Text",
"TextTrackList",
"TimeRanges",
"TreeWalker",
"VideoColorSpace",
"Window",
"XPathExpression",
Expand Down
0 src/DOM/AbstractRange.res → src/dom-nodes/AbstractRange.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Attr.res → src/dom-nodes/Attr.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/CDATASection.res → src/dom-nodes/CDATASection.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/CaretPosition.res → src/dom-nodes/CaretPosition.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/CharacterData.res → src/dom-nodes/CharacterData.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Comment.res → src/dom-nodes/Comment.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/DOMImplementation.res → src/dom-nodes/DOMImplementation.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/DOMTree.res → src/dom-nodes/DOMTree.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/DocumentFragment.res → src/dom-nodes/DocumentFragment.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Element.res → src/dom-nodes/Element.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/ElementInternals.res → src/dom-nodes/ElementInternals.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/HTML.res → src/dom-nodes/HTML.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/HTMLCollection.res → src/dom-nodes/HTMLCollection.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/NamedNodeMap.res → src/dom-nodes/NamedNodeMap.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Node.res → src/dom-nodes/Node.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/NodeFilter.res → src/dom-nodes/NodeFilter.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/NodeIterator.res → src/dom-nodes/NodeIterator.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/NodeList.res → src/dom-nodes/NodeList.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/ProcessingInstruction.res → src/dom-nodes/ProcessingInstruction.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Range.res → src/dom-nodes/Range.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Selection.res → src/dom-nodes/Selection.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/ShadowRoot.res → src/dom-nodes/ShadowRoot.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/StaticRange.res → src/dom-nodes/StaticRange.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Text.res → src/dom-nodes/Text.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/TreeWalker.res → src/dom-nodes/TreeWalker.res
View file
Open in desktop
File renamed without changes.