Skip to content

refactor: establish SVG folder feature #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
Open

refactor: establish SVG folder feature #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"WebAPI.HTML": ["WebAPI.DOMNodes", "WebAPI.File", "HTML"],
"WebAPI.Media": ["WebAPI.HTML", "Media"],
"WebAPI.WebAudio": ["WebAPI.Media", "WebAPI.Messaging", "WebAudio"],
"WebAPI.SVG": ["WebAPI.DOMNodes", "WebAPI.Geometry", "SVG"],
"WebAPI.File": ["WebAPI.Event", "File"],
"WebAPI.URL": ["WebAPI.DOM", "URL"],
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
Expand Down Expand Up @@ -120,6 +121,16 @@
"DOMRectReadOnly"
]
},
{
"dir": "src/svg",
"subdirs": true,
"feature": "SVG",

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Make Canvas builds imply the new SVG feature

When a feature-gated build includes WebAPI.Canvas but omits the new WebAPI.SVG feature, moving these modules behind SVG makes Canvas fail because VideoFrame.res, Canvas.res, and CanvasRenderingContext2D.res reference SVGElement. I verified this by enabling every existing source feature except SVG: the parent compiles all 371 modules, while this commit reports that SVGElement cannot be found. Add a Canvas-to-SVG dependency edge so consumers do not need to discover this transitive requirement manually.

Useful? React with 👍 / 👎.

"public": [
"SVGElement",
"SVGGraphicsElement",
"SVGLength"
]
},
{
"dir": "src/css-font-loading",
"subdirs": true,
Expand Down Expand Up @@ -260,9 +271,6 @@
"ImageData",
"Location",
"Navigator",
"SVGElement",
"SVGGraphicsElement",
"SVGLength",
"ScreenOrientation",
"VideoColorSpace",
"Window",
Expand Down
0 src/DOM/SVGElement.res → src/svg/SVGElement.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/SVGGraphicsElement.res → src/svg/SVGGraphicsElement.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/SVGLength.res → src/svg/SVGLength.res
View file
Open in desktop
File renamed without changes.