Skip to content

refactor: establish Storage folder feature - #334

Open
jderochervlk wants to merge 1 commit into
codex/option5-canvas-folderfrom
codex/option5-storage-folder
Open

refactor: establish Storage folder feature#334
jderochervlk wants to merge 1 commit into
codex/option5-canvas-folderfrom
codex/option5-storage-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 24 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #333.

Summary

  • add the target src/storage folder on the unqualified internal Storage feature
  • consolidate Web Storage, Storage Manager, IndexedDB, Cache, and CacheStorage bindings
  • add the supported WebAPI.Storage -> WebAPI.Fetch + Storage feature
  • preserve all existing flat storage/database/cache module paths

Boundary note

Cache and CacheStorage move out of the old ServiceWorker/WebWorkers folders because they are available outside workers and their Request/Response signatures explain Storage's Fetch dependency. The remaining worker and service-worker interfaces move together in the next PR.

Temporary state

  • WebWorkersTypes currently mixes cache and worker support types, so it moves with Storage for this layer; Workers consumes it through WebAPI.Storage, and final helper cleanup can split it after the graph is complete
  • the old WebAPI.ServiceWorker and WebAPI.WebWorkers source features are transitional until the immediately following Workers PR
  • Window and DomGlobal still reference the cache types and are resolved by the later Window integration
  • final feature-graph guardrails and cleanup remain deferred until the stack is complete

Review focus

  • Storage membership, especially Cache and CacheStorage
  • the Fetch dependency closure
  • the temporary mixed support-module ownership

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,File,URL,Fetch,Storage
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 2f0d59dd2d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-storage-folder branch from 2f0d59d to bd7c33f Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant