Version 0.16.0 beta.1 - #162
Conversation
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83b15df71b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { | ||
| "name": "@rescript/react", | ||
| "version": "0.16.0", | ||
| "version": "0.16.0-beta.1", |
There was a problem hiding this comment.
When releasing this version with the matching v0.16.0-beta.1 tag, the Configure release step in .github/workflows/publish.yml rejects it because line 63 accepts only vX.X.X; conversely, a permitted v0.16.0 tag then fails the package-version equality check on line 69. Consequently, no release tag can publish this beta through the repository's npm workflow, so the tag validation needs to support prerelease suffixes.
Useful? React with 👍 / 👎.
tsnobip
left a comment
tsnobip
left a comment
There was a problem hiding this comment.
except from the potential prerelease tag issue, it looks good to me
48cb716 to
9fcb2b7
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fcb2b7d23
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ ! "$GITHUB_REF_NAME" =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then | ||
| echo "::error::Release tags must match vX.X.X, got $GITHUB_REF_NAME." | ||
| if [[ ! "$GITHUB_REF_NAME" =~ ^v[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*)?$ ]]; then |
There was a problem hiding this comment.
When a tag such as v0.16.0-beta.1 passes this newly widened check, the publish step runs npm publish without --tag; the npm publish documentation specifies that the tag defaults to latest and is added to the submitted package. Publishing this beta would therefore replace @rescript/react's latest version, causing ordinary unversioned installs to receive a prerelease that requires an alpha ReScript runtime; select an explicit non-latest dist-tag whenever PACKAGE_VERSION is a prerelease.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
3 participants
No description provided.