Avoid per-config wide-row queries in MCP tools - #659
Merged
Conversation
find_failure_origin issued SELECT reports.* per configuration, which took 2-5 seconds each on production (no composite index covers the datetime sort and each row carries the multi-KB ltsv column) and hit Heroku's 30s H12 timeout. Scan the window once with a narrow pluck and load only the boundary reports by id. failing_servers had the same shape in its latest-report check; replace it with one grouped query. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After deploying #658,
find_failure_originwithout aserverargument times out with Heroku H12. It issuedSELECT reports.*per configuration, and each of those took 2 to 5 seconds on production because no composite index covers thedatetimesort and every row carries the multi-KBltsvcolumn, so a few dozen configurations exceed the 30s limit. This scans the lookback window once with a narrowpluck, resolves the failing-streak boundaries in Ruby, and loads only the boundary reports by primary key.failing_servershad the same query shape in its latest-report check, which is now a single groupedmaximum(:id)query. Tool output is unchanged.🤖 Generated with Claude Code