feat(newsletters): add superuser audience targeting by BillLeoutsakosvl346 · Pull Request #6069 · simstudioai/sim

BillLeoutsakosvl346 · 2026-07-29T23:45:58Z

Summary

add a superuser-only newsletter audience builder with allowlisted natural-language targeting and immutable recipient snapshots
export consent-filtered CSVs or sync recipients to Resend Segments through resumable background jobs
add audited persistence, safety limits, recovery handling, and newsletter history/status UI

Type of Change

New feature

Testing

Focused Vitest suite (44 tests)
bun run type-check
bun run check:api-validation:strict
bun run check:migrations origin/staging
Full pre-ship audit suite

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-07-29T23:46:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview	Jul 30, 2026 10:55am

cursor · 2026-07-29T23:46:08Z

PR Summary

High Risk
Touches bulk user email data, marketing consent filters, and external Resend sync with new superuser APIs; incorrect targeting or sync bugs could affect many recipients or leak audience data.

Overview
Adds a superuser-only Newsletters settings area (gated by effective superuser mode, not just platform admin) for building marketing audience runs from allowlisted natural-language targeting prompts, with preview counts and immutable snapshots after finalize.

New /api/superuser/newsletters endpoints support listing/creating runs, finalizing audiences (Resend suppressions + safety cap), streaming consent-filtered CSV export, enqueueing Resend segment sync, and polling background job status. Persistence uses new newsletter_audience_runs / newsletter_audience_recipients tables and a Resend client with pagination, retries, and typed service errors mapped to 503 where appropriate.

Resend push runs as newsletter-resend-sync (Trigger.dev or inline database queue). Enqueue/resume logic reconciles stuck or duplicate provider jobs. The database async job backend gains inline claim tokens, lease heartbeats, and safer duplicate/retry behavior so newsletter sync can run inline without double-processing.

Account settings navigation fixes Mothership routing (no longer the default fallback for unknown sections).

^{Reviewed by Cursor Bugbot for commit 493375b. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-07-29T23:51:07Z

Greptile Summary

Superuser newsletter audience targeting with immutable recipient snapshots, consent-filtered CSV export, and Resend segment sync via resumable background jobs.

Adds newsletter runs schema/migration, targeting, finalize/export/push APIs, and audited run status UI under account settings.
Resend suppressions/contacts paginate fail-closed; Trigger.dev resume fences completed/failed/active/missing provider jobs and restarts attempts from durable run state.
Account settings renderer branches newsletters explicitly and fails closed on unknown sections.

Confidence Score: 5/5

Prior Greptile findings are addressed at HEAD; the PR appears safe to merge from those resume, pagination, and settings-renderer issues.

Suppression pagination, Trigger.dev resume recovery (including completed-but-still-pushing), and account-settings fail-closed behavior are present with tests; no remaining blocking failure from the prior threads.

Important Files Changed

Filename	Overview
apps/sim/lib/newsletters/push-resend.ts	Resume treats durable run status as source of truth; completed/failed/missing/active Trigger.dev jobs are fenced and restarted with new attempt keys.
apps/sim/lib/newsletters/resend.ts	Suppression and contact exclusion lists paginate with cursors, validation, and safety caps.
apps/sim/components/settings/account-settings-renderer.tsx	Explicit newsletters branch; unknown account sections render null.
apps/sim/lib/newsletters/runs.ts	Attempt claiming, job/segment fencing, and pushed/failed transitions back resume recovery.

Sequence Diagram

sequenceDiagram
  participant Admin as Superuser UI
  participant API as Newsletter APIs
  participant Runs as runs.ts
  participant Queue as Job queue
  participant Worker as runNewsletterResendSync
  participant Resend as Resend API

  Admin->>API: finalize run
  API->>Runs: snapshot recipients
  Admin->>API: push / resume
  API->>Runs: claimNewsletterRunResendAttempt
  alt stored job terminal or active (non-DB)
    API->>Queue: getJob / cancelJob
    API->>Runs: mark failed attempt + re-claim
  end
  API->>Queue: enqueue newsletter-resend-sync
  API->>Runs: setNewsletterRunResendJob
  Queue->>Worker: payload + attempt
  Worker->>Resend: segment, properties, contacts
  Worker->>Runs: mark pushed or failed

_{Reviews (7): Last reviewed commit: "fix(newsletters): fence resend recovery ..." | Re-trigger Greptile}

BillLeoutsakosvl346 · 2026-07-30T00:05:38Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T00:05:39Z

@cursor review

BillLeoutsakosvl346 · 2026-07-30T00:18:15Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T00:18:16Z

@cursor review

BillLeoutsakosvl346 · 2026-07-30T01:01:59Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T01:02:00Z

@cursor review

BillLeoutsakosvl346 · 2026-07-30T01:24:51Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T01:24:52Z

@cursor review

BillLeoutsakosvl346 · 2026-07-30T01:50:18Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T01:50:19Z

@cursor review

cursor · 2026-07-30T10:58:51Z

+            >
+              {finalizePending ? 'Finalizing...' : 'Finalize'}
+            </Chip>
+          )}


Stuck finalizing runs unreclaimable

Medium Severity

canFinalize only allows draft, so a run left in finalizing after a crashed or timed-out finalize never shows a Finalize action. The API can reclaim stale finalizing rows, but the UI never offers that path, leaving operators unable to recover without a manual API call.

^{Reviewed by Cursor Bugbot for commit 493375b. Configure here.}

cursor · 2026-07-30T10:58:51Z

+        AND cc.deleted_at IS NULL
+        AND cm.deleted_at IS NULL
+        AND cm.role = 'user'
+        AND lower(cm.content::text) LIKE ${pattern}


Chat targeting scans full JSON

Medium Severity

chat_mentions matching runs LIKE over cm.content::text, but copilot_messages.content stores the full PersistedMessage JSON. Users can enter the audience via attachment names, context blockType values, or other metadata containing the term, not only message text, so Instagram chat targeting can over-include recipients.

^{Reviewed by Cursor Bugbot for commit 493375b. Configure here.}

BillLeoutsakosvl346 · 2026-07-30T11:25:37Z

@greptile

BillLeoutsakosvl346 · 2026-07-30T11:25:38Z

@cursor review

cursor

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 493375b. Configure here.}

cursor · 2026-07-30T11:34:04Z

+      { cause: error }
+    )
+  }
+  return { run: updatedRun, jobId: updatedRun.resendSyncJobId ?? jobId }


Resume can attach a finished job

Medium Severity

When shouldEnqueue is true because tracking was never persisted, enqueue reuses the attempt idempotency key. If that provider job already finished, Trigger/DB return the terminal job without running again, then setNewsletterRunResendJob stores it and the API succeeds while the run stays pushing with no worker. Recovery needs another resume after reconciliation sees the completed/failed job.

^{Reviewed by Cursor Bugbot for commit 493375b. Configure here.}

vercel Bot deployed to Preview July 29, 2026 23:50 View deployment

greptile-apps Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/resend.ts Outdated

Comment thread apps/sim/lib/newsletters/push-resend.ts

Comment thread apps/sim/components/settings/account-settings-renderer.tsx

cursor Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/resend.ts

vercel Bot temporarily deployed to Preview July 30, 2026 00:03 Inactive

BillLeoutsakosvl346 force-pushed the admin-newsletter-targeting branch from 59bdf0b to 4fbd67c Compare July 30, 2026 00:05

vercel Bot temporarily deployed to Preview July 30, 2026 00:05 Inactive

greptile-apps Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/push-resend.ts Outdated

BillLeoutsakosvl346 force-pushed the admin-newsletter-targeting branch from 4fbd67c to 849323e Compare July 30, 2026 00:17

vercel Bot deployed to Preview July 30, 2026 00:23 View deployment

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/push-resend.ts

BillLeoutsakosvl346 force-pushed the admin-newsletter-targeting branch from 849323e to 4e522cd Compare July 30, 2026 01:01

vercel Bot deployed to Preview July 30, 2026 01:05 View deployment

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/sim/background/newsletter-resend-sync.ts Outdated

vercel Bot temporarily deployed to Preview July 30, 2026 01:20 Inactive

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/runs.ts

Comment thread apps/sim/lib/core/async-jobs/backends/database.ts

BillLeoutsakosvl346 force-pushed the admin-newsletter-targeting branch from f8c79bf to c56913a Compare July 30, 2026 01:49

vercel Bot deployed to Preview July 30, 2026 01:53 View deployment

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread apps/sim/lib/newsletters/push-resend.ts

Comment thread apps/sim/lib/newsletters/push-resend.ts

Comment thread apps/sim/app/api/superuser/newsletters/runs/[id]/finalize/route.ts

Bill Leoutsakos added 5 commits July 30, 2026 02:40

feat(newsletters): add superuser audience targeting

734a067

fix(newsletters): handle review recovery cases

46eb81e

fix(newsletters): propagate sync cancellation

928a7c9

fix(newsletters): keep exports and recovery responsive

07ff1c5

fix(newsletters): fence resend recovery state

493375b

BillLeoutsakosvl346 force-pushed the admin-newsletter-targeting branch from c56913a to 493375b Compare July 30, 2026 10:50

vercel Bot deployed to Preview July 30, 2026 10:55 View deployment

cursor Bot reviewed Jul 30, 2026

View reviewed changes

Uh oh!

Conversation

BillLeoutsakosvl346 commented Jul 29, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot Jul 30, 2026

Choose a reason for hiding this comment

Stuck finalizing runs unreclaimable

Uh oh!

cursor Bot Jul 30, 2026

Choose a reason for hiding this comment

Chat targeting scans full JSON

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

BillLeoutsakosvl346 commented Jul 30, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 30, 2026

Choose a reason for hiding this comment

Resume can attach a finished job

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

vercel Bot commented Jul 29, 2026 •

edited

Loading

cursor Bot commented Jul 29, 2026 •

edited

Loading

greptile-apps Bot commented Jul 29, 2026 •

edited

Loading